From: Andrea Arcangeli <andrea@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: oskar@osk.mine.nu, linux-kernel@vger.kernel.org
Subject: Re: directory notifications lost after fork?
Date: Tue, 12 Mar 2002 05:01:04 +0100 [thread overview]
Message-ID: <20020312050104.V10413@dualathlon.random> (raw)
In-Reply-To: <20020310210802.GA1695@oskar> <20020311112652.E10413@dualathlon.random> <20020312120452.3038c4bc.sfr@canb.auug.org.au> <20020312022046.R10413@dualathlon.random> <20020312135949.3be7d9ca.sfr@canb.auug.org.au>
In-Reply-To: <20020312135949.3be7d9ca.sfr@canb.auug.org.au>
On Tue, Mar 12, 2002 at 01:59:49PM +1100, Stephen Rothwell wrote:
> My patch makes directory notifiers per thread group instead of per process
> tree (which they are now).
I overlooked that in your patch you changed the index for the lookup, so
yes, that looks a better fix.
> This would be equivalent to returning -EPERM if you tried to remove a
> lock on a file when you didn't set it ...
Lock are standard and we cannot change such API, but for a fairly new
API I'd prefer strict stuff. Anyways now -EPERM would be wrong and the
need of the errorback is also lower because there's no risk of
collisions anymore, now different current->files will be able to get
different notifiers, so if something it should be a -ENOENT, it's not a
matter of permissions/ownership anymore.
Andrea
next prev parent reply other threads:[~2002-03-12 4:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-10 21:08 directory notifications lost after fork? Oskar Liljeblad
2002-03-11 7:41 ` Alex Riesen
2002-03-12 12:19 ` Jamie Lokier
2002-03-11 8:50 ` Oskar Liljeblad
2002-03-11 10:20 ` Alex Riesen
2002-03-11 10:26 ` Andrea Arcangeli
2002-03-12 1:04 ` Stephen Rothwell
2002-03-12 1:20 ` Andrea Arcangeli
2002-03-12 2:59 ` Stephen Rothwell
2002-03-12 4:01 ` Andrea Arcangeli [this message]
[not found] <20020311122701.A9718@riesen-pc.gr05.synopsys.com>
2002-03-11 19:34 ` Alex Riesen
-- strict thread matches above, loose matches on Subject: below --
2002-03-12 1:47 Malte Starostik
2002-03-12 12:55 ` Jamie Lokier
2002-03-12 16:37 ` Daniel Phillips
2002-03-12 17:21 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020312050104.V10413@dualathlon.random \
--to=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@osk.mine.nu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.