make install bug?

make install bug?

[Dale Amon]

When building kernels for my servers I have always done this:

	make INSTALL_MOD_PATH=/usr/src/<target-hostname> modules_install

to dump all the modules into an easily tarballable directory 
to be scp'd to the target host.

However for some reason today it's tried to do a depmod on the 
kernel building machine:

make -C  arch/i386/lib modules_install
make[1]: Entering directory `/VNetLinux/linux-2.4.18/arch/i386/lib'
make[1]: Nothing to be done for `modules_install'.
make[1]: Leaving directory `/VNetLinux/linux-2.4.18/arch/i386/lib'
cd /VNetLinux/scout/lib/modules/2.4.18; \
mkdir -p pcmcia; \
find kernel -path '*/pcmcia/*' -name '*.o' | xargs -i -r ln -sf ../{} pcmcia
if [ -r System.map ]; then /sbin/depmod -ae -F System.map -b /VNetLinux/scout -r 2.4.18; fi
depmod: *** Unresolved symbols in /VNetLinux/scout/lib/modules/2.4.18/pcmcia/3c575_cb.o
depmod:         pcibios_read_config_byte
depmod:         pcibios_write_config_word
depmod:         pcibios_read_config_dword
depmod:         pcibios_write_config_byte
depmod:         pcibios_write_config_dword
depmod:         pcibios_read_config_word
depmod: *** Unresolved symbols in /VNetLinux/scout/lib/modules/2.4.18/pcmcia/aha152x_cs.o
depmod:         print_msg
depmod:         scsi_command_size
depmod:         scsi_unregister_module
depmod:         scsicam_bios_param
	And so forth....


I'm not sure why this started happening, but it isn't nice
behavior at all. I'd call it a bug as I can't imagine why
I'd want a depmod to occur on the build machine.

Have I managed to tickle something that should not be 
happening?

Re: make install bug?

[Dale Amon]

On Sat, Apr 06, 2002 at 04:15:31PM +0100, Dale Amon wrote:
> I'm not sure why this started happening, but it isn't nice
> behavior at all. I'd call it a bug as I can't imagine why
> I'd want a depmod to occur on the build machine.

Hmmm, I think I failed to engage brain before fingers. Sent
the files to a non-existant directory... which might be
the thing that tickled it to do the depmod?

Re: make install bug?

[Keith Owens]

On Sat, 6 Apr 2002 16:15:31 +0100, 
Dale Amon <amon@vnl.com> wrote:
>make[1]: Leaving directory `/VNetLinux/linux-2.4.18/arch/i386/lib'
>I'm not sure why this started happening, but it isn't nice
>behavior at all. I'd call it a bug as I can't imagine why
>I'd want a depmod to occur on the build machine.

depmod runs at build time as a courtesy, to build the modules.dep for
the initial boot, otherwise you get warning messages on the first boot
of a new kernel.  For cross compiling or building for a different
machine, you can turn depmod into a no-op with make DEPMOD=/bin/true.

make install bug?

[eschvoca]

Using the latest git on "make prefix=/home/eschvoca/apps/git-0.99.9m
install" I get the following error:

make[1]: Entering directory `/home/eschvoca/downloads/git-0.99.9m/templates'
: no custom templates yet
install -d -m755 '/home/eschvoca/share/git-core/templates/'
(cd blt && tar cf - .) | \
(cd '/home/eschvoca/share/git-core/templates/' && tar xf -)
tar: This does not look like a tar archive
tar: Skipping to next header
tar: Error exit delayed from previous errors
make[1]: *** [install] Error 2


I can fix the problem by changing templates/Makefile to the following:

install: all
    $(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))
    (cd blt && $(TAR) cf - . > /tmp/a.tar) | \
    (cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf /tmp/a.tar)

Re: make install bug?

[Junio C Hamano]

eschvoca <eschvoca@gmail.com> writes:

> I can fix the problem by changing templates/Makefile to the following:
>
> install: all
>     $(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))
>     (cd blt && $(TAR) cf - . > /tmp/a.tar) | \
>     (cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf /tmp/a.tar)

Here is my guess.  Could you try, from your interactive shell:

	$ (unset CDPATH; make install)

first without the above "fix" (your "fixed" pipe does not make
any sense --- what are the data passed between pipe upstream and
downstream?)?

If that makes the problem go away, then your environment is
broken --- my guess is that you are exporting CDPATH to
non-interactive scripts.  Don't do that.

I once googled for "CDPATH" and saw many "guide to unix" type
webpages talk about "CDPATH environment variable"; they are the
real culprit to cause this confusion in peoples' .bash_profile.
CDPATH might be a nice variable for interactive shells, but is a
horrible one if made environment.

Re: make install bug?

[eschvoca]

You are right, CDPATH is the problem.  I am no longer exporting CDPATH.

e

On 12/12/05, Junio C Hamano <junkio@cox.net> wrote:
> eschvoca <eschvoca@gmail.com> writes:
>
> > I can fix the problem by changing templates/Makefile to the following:
> >
> > install: all
> >     $(INSTALL) -d -m755 $(call shellquote,$(DESTDIR)$(template_dir))
> >     (cd blt && $(TAR) cf - . > /tmp/a.tar) | \
> >     (cd $(call shellquote,$(DESTDIR)$(template_dir)) && $(TAR) xf /tmp/a.tar)
>
> Here is my guess.  Could you try, from your interactive shell:
>
>         $ (unset CDPATH; make install)
>
> first without the above "fix" (your "fixed" pipe does not make
> any sense --- what are the data passed between pipe upstream and
> downstream?)?
>
> If that makes the problem go away, then your environment is
> broken --- my guess is that you are exporting CDPATH to
> non-interactive scripts.  Don't do that.
>
> I once googled for "CDPATH" and saw many "guide to unix" type
> webpages talk about "CDPATH environment variable"; they are the
> real culprit to cause this confusion in peoples' .bash_profile.
> CDPATH might be a nice variable for interactive shells, but is a
> horrible one if made environment.
>
>