* Re: AMD PowerNow booboo in 2.4.19-pre7-ac3
2002-05-02 9:17 ` Russell King
@ 2002-05-02 9:19 ` CaT
2002-05-02 13:25 ` Dave Jones
2002-05-02 13:47 ` SANDEEP DEY
2 siblings, 0 replies; 6+ messages in thread
From: CaT @ 2002-05-02 9:19 UTC (permalink / raw)
To: Russell King; +Cc: linux-kernel, cpufreq
On Thu, May 02, 2002 at 10:17:23AM +0100, Russell King wrote:
> On Thu, May 02, 2002 at 06:51:37PM +1000, CaT wrote:
> > --- arch/i386/kernel/amdk6plus.c.old Thu May 2 18:51:13 2002
> > +++ arch/i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002
> > @@ -117,4 +117,4 @@
> > MODULE_LICENSE ("GPL");
> > module_init(PowerNow_k6plus_init);
> > module_exit(PowerNow_k6plus_exit);
> > -__initcall (PowerNOW_k6plus_init);
> > +__initcall (PowerNow_k6plus_init);
>
> Hmm, that looks really odd - module_init() should be identical to __initcall
> when built into the kernel. Copied to the cpufreq list.
I did a test make bzlilo to continue compiling and that -seemed- to work
but I probably did something wrong as it bombed out with a 'duplicate
definition' (from memory) so I removed the __initcall and it compiled
fine this time.
--
CORUSCANT-Presiding over a memorial service commemorating the victims
of the attack on the Death Star, the Emperor declared that while recent
victories over the Rebel Alliance were "encouraging, the War on Terror
is not over yet."
- http://www.zip.com.au/~cat/misc/txt/waronterror.txt
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: AMD PowerNow booboo in 2.4.19-pre7-ac3
2002-05-02 9:17 ` Russell King
2002-05-02 9:19 ` CaT
@ 2002-05-02 13:25 ` Dave Jones
2002-05-02 14:20 ` Alan Cox
2002-05-02 13:47 ` SANDEEP DEY
2 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2002-05-02 13:25 UTC (permalink / raw)
To: Russell King; +Cc: CaT, linux-kernel, cpufreq
On Thu, May 02, 2002 at 10:17:23AM +0100, Russell King wrote:
> > MODULE_LICENSE ("GPL");
> > module_init(PowerNow_k6plus_init);
> > module_exit(PowerNow_k6plus_exit);
> > -__initcall (PowerNOW_k6plus_init);
> > +__initcall (PowerNow_k6plus_init);
> >
> Hmm, that looks really odd - module_init() should be identical to __initcall
> when built into the kernel. Copied to the cpufreq list.
Odd, Alan must have merged an old version of the cvs tree, as the
initcalls were nuked a long time ago there iirc. They're certainly not
in my copy of the current tree
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: AMD PowerNow booboo in 2.4.19-pre7-ac3
2002-05-02 13:25 ` Dave Jones
@ 2002-05-02 14:20 ` Alan Cox
0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2002-05-02 14:20 UTC (permalink / raw)
To: Dave Jones; +Cc: Russell King, CaT, linux-kernel, cpufreq
> Odd, Alan must have merged an old version of the cvs tree, as the
> initcalls were nuked a long time ago there iirc. They're certainly not
> in my copy of the current tree
I merged head at the time of the merge, and told you about the initcalls
when I merged them 8). It does need updating especially now spudstop support
is in
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: AMD PowerNow booboo in 2.4.19-pre7-ac3
2002-05-02 9:17 ` Russell King
2002-05-02 9:19 ` CaT
2002-05-02 13:25 ` Dave Jones
@ 2002-05-02 13:47 ` SANDEEP DEY
2 siblings, 0 replies; 6+ messages in thread
From: SANDEEP DEY @ 2002-05-02 13:47 UTC (permalink / raw)
To: sandeep dey; +Cc: linux-kernel
SANDEEP DEY,
ROOM NO.308,
HALL 3,
IIT KANPUR,
KANPUR 208016.
"I am a slow walker but i do not walk backwards."
Abraham Lincoln....
On Thu, 2 May 2002, Russell King wrote:
> On Thu, May 02, 2002 at 06:51:37PM +1000, CaT wrote:
> > --- arch/i386/kernel/amdk6plus.c.old Thu May 2 18:51:13 2002
> > +++ arch/i386/kernel/amdk6plus.c Thu May 2 18:51:17 2002
> > @@ -117,4 +117,4 @@
> > MODULE_LICENSE ("GPL");
> > module_init(PowerNow_k6plus_init);
> > module_exit(PowerNow_k6plus_exit);
> > -__initcall (PowerNOW_k6plus_init);
> > +__initcall (PowerNow_k6plus_init);
> >
>
> Hmm, that looks really odd - module_init() should be identical to __initcall
> when built into the kernel. Copied to the cpufreq list.
>
> --
> Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
> http://www.arm.linux.org.uk/personal/aboutme.html
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread