From: "David S. Miller" <davem@redhat.com>
To: andrea@suse.de
Cc: hugh@veritas.com, torvalds@transmeta.com, akpm@zip.com.au,
cr@sap.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] double flush_page_to_ram
Date: Thu, 09 May 2002 05:52:00 -0700 (PDT) [thread overview]
Message-ID: <20020509.055200.111470847.davem@redhat.com> (raw)
In-Reply-To: <20020509150146.O12382@dualathlon.random>
From: Andrea Arcangeli <andrea@suse.de>
Date: Thu, 9 May 2002 15:01:46 +0200
On Thu, May 09, 2002 at 04:56:43AM -0700, David S. Miller wrote:
> Wrong, consider the case where we do early COW in do_no_page, you miss
> a flush on the new-new page.
so you mean we need a flush_page_to_ram also before the
copy_user_highpage to be sure we copy uptodate contents of the
pagecache? (possibly mapped writeable elsewhere in the user address
space?)
That is correct.
The fact that this ends up with multiple flushes is one of
several reasons why Documentation/cachetlb.txt encourages
ports to move to the newer way to handle this (flush_dcache_page()
plus bits in {copy,clear}_user_page() to handle the cache issues
and not using flush_page_to_ram() at all).
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2002-05-09 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-09 12:03 [PATCH] double flush_page_to_ram Hugh Dickins
2002-05-09 11:56 ` David S. Miller
2002-05-09 13:01 ` Andrea Arcangeli
2002-05-09 12:52 ` David S. Miller [this message]
2002-05-09 13:21 ` Andrea Arcangeli
2002-05-09 13:13 ` David S. Miller
2002-05-09 13:44 ` Andrea Arcangeli
2002-05-09 13:35 ` David S. Miller
2002-05-09 13:50 ` Hugh Dickins
2002-05-09 14:16 ` David S. Miller
2002-05-09 13:18 ` Hugh Dickins
2002-05-09 13:07 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020509.055200.111470847.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@zip.com.au \
--cc=andrea@suse.de \
--cc=cr@sap.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.