From: "David S. Miller" <davem@redhat.com>
To: hugh@veritas.com
Cc: torvalds@transmeta.com, akpm@zip.com.au, cr@sap.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] double flush_page_to_ram
Date: Thu, 09 May 2002 06:07:03 -0700 (PDT) [thread overview]
Message-ID: <20020509.060703.121443473.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0205091416360.10889-100000@localhost.localdomain>
From: Hugh Dickins <hugh@veritas.com>
Date: Thu, 9 May 2002 14:18:49 +0100 (BST)
On Thu, 9 May 2002, David S. Miller wrote:
> Wrong, consider the case where we do early COW in do_no_page, you miss
> a flush on the new-new page.
Of course we do, and then we don't map it into user address space;
if it ever gets mapped into user address space later, do_no_page
does the flush_page_to_ram then.
You miss the fact that if we do an early COW and another process
recently WROTE into that page via a shared MMAP, we will potentially
copy old data into the COW page we use for the current process.
Your changes are wrong and will cause corruption.
prev parent reply other threads:[~2002-05-09 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-09 12:03 [PATCH] double flush_page_to_ram Hugh Dickins
2002-05-09 11:56 ` David S. Miller
2002-05-09 13:01 ` Andrea Arcangeli
2002-05-09 12:52 ` David S. Miller
2002-05-09 13:21 ` Andrea Arcangeli
2002-05-09 13:13 ` David S. Miller
2002-05-09 13:44 ` Andrea Arcangeli
2002-05-09 13:35 ` David S. Miller
2002-05-09 13:50 ` Hugh Dickins
2002-05-09 14:16 ` David S. Miller
2002-05-09 13:18 ` Hugh Dickins
2002-05-09 13:07 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020509.060703.121443473.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@zip.com.au \
--cc=cr@sap.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.