All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: linux-kernel@vger.kernel.org
Subject: 2.5.21: kbuild changes broke filenames with commas
Date: Sun, 9 Jun 2002 17:58:04 +0100	[thread overview]
Message-ID: <20020609175804.B8761@flint.arm.linux.org.uk> (raw)

With the latest kbuild version in 2.5.21, we are unable to build the
following files:

linux/drivers/block/smart1,2.h
linux/drivers/scsi/53c7,8xx.c
linux/drivers/scsi/53c7,8xx.h
linux/drivers/scsi/53c7,8xx.scr
linux/arch/arm/mm/proc-arm6,7.S
linux/arch/arm/mm/proc-arm2,3.S

This is because we end up passing gcc the following argument:

	-Wp,-MD,.proc-arm6,7.o.d

which gets passed to cpp0 as:

	-MD .proc-arm6 7.o.d
	              ^ space, not comma

and therefore cpp0 sees "-MD", ".proc-arm6" and "7.o.d" as separate
arguments.

There seems to be two solutions:

1. renaming all the above files to contain '_' instead of ','.
2. see if kbuild can use the DEPENDENCIES_OUTPUT environment variable

Kai pointed out that we've already got one exception in kbuild to fixup
the filename for KBUILD_BASENAME (, -> _ and that's not a weird smilie!)
so (1) is probably going to be better, and we can get rid of the special
"comma" handling.

Either way, I plan to rename the two ARM files.  That leaves the 53c7,8xx
driver and that block header file.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


             reply	other threads:[~2002-06-09 16:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-09 16:58 Russell King [this message]
2002-06-09 17:11 ` Upper limits to number of processes / threads in Linux / ia32?? M. Edward (Ed) Borasky
2002-06-09 18:02 ` 2.5.21: kbuild changes broke filenames with commas Kai Germaschewski
2002-06-09 18:34 ` Tom Rini
2002-06-10 23:02 ` Keith Owens
2002-06-11  7:39   ` Russell King
2002-06-11 11:11     ` Thunder from the hill
2002-06-11 11:21       ` Russell King
2002-06-11 12:16         ` Thunder from the hill
2002-06-11 13:01           ` Russell King
2002-06-12 14:36           ` Ingo Oeser
2002-06-12 18:10             ` Thunder from the hill
2002-06-13 20:12         ` Thunder from the hill
2002-06-11 16:08     ` Daniel Phillips
2002-06-11 16:14       ` Alexander Viro
2002-06-11 16:22         ` Daniel Phillips
2002-06-11 16:31       ` Russell King
2002-06-11 16:36         ` Daniel Phillips
  -- strict thread matches above, loose matches on Subject: below --
2002-06-11 23:55 Keith Owens
2002-06-12  0:27 ` Kai Germaschewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020609175804.B8761@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.