All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhishek Nayani <abhi@kernelnewbies.org>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: [BUG] in do_mmap_pgoff() (2.4.19-preX)
Date: Mon, 17 Jun 2002 00:46:06 +0530	[thread overview]
Message-ID: <20020616191606.GA1888@SandStorm.net> (raw)

Hi,

	While documenting the do_mmap_pgoff() function, i found this
snippet of code very suspicious:

        /* Private writable mapping? Check memory availability.. */
	        if ((vm_flags & (VM_SHARED | VM_WRITE)) == VM_WRITE &&
                                           !(flags & MAP_NORESERVE) &&
			          !vm_enough_memory(len >> PAGE_SHIFT))
			return -ENOMEM; 
											 
	Here we need to quit if *any* one of the condition is true. So I
think it should be "||" instead of "&&". As according to the present
code, it quits only if all the 3 conditions is true, which is wrong.




					Bye,
						Abhi.
	
	
Linux Kernel Documentation Project
http://freesoftware.fsf.org/lkdp
--------------------------------------------------------------------------------
Those who cannot remember the past are condemned to repeat it - George Santayana
--------------------------------------------------------------------------------
                          Home Page: http://www.abhi.tk
-----BEGIN GEEK CODE BLOCK------------------------------------------------------
GCS d+ s:- a-- C+++ UL P+ L+++ E- W++ N+ o K- w--- O-- M- V- PS PE Y PGP 
t+ 5 X+ R- tv+ b+++ DI+ D G e++ h! !r y- 
------END GEEK CODE BLOCK-------------------------------------------------------

WARNING: multiple messages have this Message-ID (diff)
From: Abhishek Nayani <abhi@kernelnewbies.org>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: [BUG] in do_mmap_pgoff() (2.4.19-preX)
Date: Mon, 17 Jun 2002 00:46:06 +0530	[thread overview]
Message-ID: <20020616191606.GA1888@SandStorm.net> (raw)

Hi,

	While documenting the do_mmap_pgoff() function, i found this
snippet of code very suspicious:

        /* Private writable mapping? Check memory availability.. */
	        if ((vm_flags & (VM_SHARED | VM_WRITE)) == VM_WRITE &&
                                           !(flags & MAP_NORESERVE) &&
			          !vm_enough_memory(len >> PAGE_SHIFT))
			return -ENOMEM; 
											 
	Here we need to quit if *any* one of the condition is true. So I
think it should be "||" instead of "&&". As according to the present
code, it quits only if all the 3 conditions is true, which is wrong.




					Bye,
						Abhi.
	
	
Linux Kernel Documentation Project
http://freesoftware.fsf.org/lkdp
--------------------------------------------------------------------------------
Those who cannot remember the past are condemned to repeat it - George Santayana
--------------------------------------------------------------------------------
                          Home Page: http://www.abhi.tk
-----BEGIN GEEK CODE BLOCK------------------------------------------------------
GCS d+ s:- a-- C+++ UL P+ L+++ E- W++ N+ o K- w--- O-- M- V- PS PE Y PGP 
t+ 5 X+ R- tv+ b+++ DI+ D G e++ h! !r y- 
------END GEEK CODE BLOCK-------------------------------------------------------
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

             reply	other threads:[~2002-06-19  6:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-16 19:16 Abhishek Nayani [this message]
2002-06-16 19:16 ` [BUG] in do_mmap_pgoff() (2.4.19-preX) Abhishek Nayani
2002-06-19 12:25 ` Rik van Riel
2002-06-19 12:25   ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020616191606.GA1888@SandStorm.net \
    --to=abhi@kernelnewbies.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.