About a patch to unclean module.

About a patch to unclean module.

[Maciej Soltysiak]

Hello,

I may say now, that I have finished writing the module, updating the
lipipt_unclean.c, I have created the patches to the netfilter tree.

But, suppose, Harald applies the patch. It will change libipt_unclean.c
in a way, that withougt running patch-o-matic it will not compile, because
it uses an include file
KERNEL_DIR/include/linux/netfilter_ipv4/ipt_unclean.h which will be only
available after patching the kernel tree.

So how do we solve that?
I see it by adding ipt_unclean.h to the netfilter tree.

Or maybe I am missing something or forgetting about something, some simple
solution.


Regards,
Maciej Soltysiak

Re: About a patch to unclean module.

[Fabrice MARIE]

Hello Maciej,

On Saturday 22 June 2002 03:00, Maciej Soltysiak wrote:
> Hello,
> I may say now, that I have finished writing the module, updating the
> lipipt_unclean.c, I have created the patches to the netfilter tree.
> But, suppose, Harald applies the patch. It will change libipt_unclean.c
> in a way, that withougt running patch-o-matic it will not compile, because
> it uses an include file
> KERNEL_DIR/include/linux/netfilter_ipv4/ipt_unclean.h which will be only
> available after patching the kernel tree.
> So how do we solve that?

The easiest way is to use the userspace patching facility of patch-o-matic.
Just look at extra/ipt_REJECT-fake-source.patch and especially
extra/ipt_REJECT-fake-source.patch.userspace for an example of userspace
patching.

> I see it by adding ipt_unclean.h to the netfilter tree.
> Or maybe I am missing something or forgetting about something, some simple
> solution.
> Regards,
> Maciej Soltysiak

Have a nice day,

Fabrice.
--
Fabrice MARIE
Senior R&D Engineer
Celestix Networks
http://www.celestix.com/

"Silly hacker, root is for administrators"
       -Unknown

Re: About a patch to unclean module.

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

On Sat, Jun 22, 2002 at 10:51:10PM +0800, Fabrice MARIE wrote:
> 
> Hello Maciej,
> 
> On Saturday 22 June 2002 03:00, Maciej Soltysiak wrote:
> > Hello,
> > I may say now, that I have finished writing the module, updating the
> > lipipt_unclean.c, I have created the patches to the netfilter tree.
> > But, suppose, Harald applies the patch. It will change libipt_unclean.c
> > in a way, that withougt running patch-o-matic it will not compile, because
> > it uses an include file
> > KERNEL_DIR/include/linux/netfilter_ipv4/ipt_unclean.h which will be only
> > available after patching the kernel tree.
> > So how do we solve that?
> 
> The easiest way is to use the userspace patching facility of patch-o-matic.

GNAH!  As soon as somebody is using this evil confusing hack without it
being absolutely necessarry, I'll start flaming him.

See my other mail in this thread.

> Fabrice.

-- 
Live long and prosper
- Harald Welte / laforge@gnumonks.org               http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+ 
V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*)

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: About a patch to unclean module.

[Maciej Soltysiak]

> The easiest way is to use the userspace patching facility of patch-o-matic.
> Just look at extra/ipt_REJECT-fake-source.patch and especially
> extra/ipt_REJECT-fake-source.patch.userspace for an example of userspace
> patching.
Argh, how obvious. :)
Thank you.

> Fabrice.
Maciej

Re: About a patch to unclean module.

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

On Fri, Jun 21, 2002 at 09:00:04PM +0200, Maciej Soltysiak wrote:
> Hello,
> 
> I may say now, that I have finished writing the module, updating the
> lipipt_unclean.c, I have created the patches to the netfilter tree.
> 
> But, suppose, Harald applies the patch. It will change libipt_unclean.c
> in a way, that withougt running patch-o-matic it will not compile, because
> it uses an include file
> KERNEL_DIR/include/linux/netfilter_ipv4/ipt_unclean.h which will be only
> available after patching the kernel tree.
> 
> So how do we solve that?

this is a comon problem, and it's always solved the same way: Put the
kernel include file into userspace/include/linux/netfilter_ipv4/.

> Maciej Soltysiak

-- 
Live long and prosper
- Harald Welte / laforge@gnumonks.org               http://www.gnumonks.org/
============================================================================
GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+ 
V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*)

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: About a patch to unclean module.

[Maciej Soltysiak]

> this is a comon problem, and it's always solved the same way: Put the
> kernel include file into userspace/include/linux/netfilter_ipv4/.
Yes Sir.
 
Maciej