From: Dave Jones <davej@suse.de>
To: Paul Menage <pmenage@ensim.com>
Cc: viro@math.psu.edu, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Rearranging struct dentry for cache affinity
Date: Fri, 12 Jul 2002 22:58:28 +0200 [thread overview]
Message-ID: <20020712225828.E18503@suse.de> (raw)
In-Reply-To: <E17T7BT-0006zT-00@pmenage-dt.ensim.com>; from pmenage@ensim.com on Fri, Jul 12, 2002 at 01:38:35PM -0700
On Fri, Jul 12, 2002 at 01:38:35PM -0700, Paul Menage wrote:
> - dentry->d_vfs_flags |= DCACHE_REFERENCED;
> +#ifdef CONFIG_SMP
> + if(!(dentry->d_vfs_flags & DCACHE_REFERENCED))
> +#endif
> + dentry->d_vfs_flags |= DCACHE_REFERENCED;
Yuck. Is doing this conditional on UP really a measurable effect?
Somehow I doubt it's worth this ugliness. If you must microoptimise
to this level, at least try and keep the code clean.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-07-12 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-12 20:38 [RFC] Rearranging struct dentry for cache affinity Paul Menage
2002-07-12 20:58 ` Dave Jones [this message]
2002-07-12 21:21 ` Paul Menage
2002-07-13 9:11 ` Alexander Viro
2002-07-16 3:54 ` Rusty Russell
2002-07-16 4:40 ` Alexander Viro
2002-07-17 0:04 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020712225828.E18503@suse.de \
--to=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmenage@ensim.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.