From: Rusty Russell <rusty@rustcorp.com.au>
To: Alexander Viro <viro@math.psu.edu>
Cc: torvalds@transmeta.com, pmenage@ensim.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Rearranging struct dentry for cache affinity
Date: Wed, 17 Jul 2002 10:04:44 +1000 [thread overview]
Message-ID: <20020717003135.ACB2D4503@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 16 Jul 2002 00:40:42 -0400." <Pine.GSO.4.21.0207160036460.24417-100000@weyl.math.psu.edu>
In message <Pine.GSO.4.21.0207160036460.24417-100000@weyl.math.psu.edu> you wri
te:
> On Tue, 16 Jul 2002, Rusty Russell wrote:
>
> > Really? Other than changing over to get_sb_psuedo(), what does your patch
> > fix? As the filesystem should never be unmounted, what am I missing?
> > > filp->f_op = &futex_fops;
> > > - filp->f_dentry = dget(futex_dentry);
> > > + filp->f_vfsmnt = mntget(futex_mnt);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > + filp->f_dentry = dget(futex_mnt->mnt_root);
>
> Uninitialized ->f_vfsmnt == quite a few places in the tree very unhappy.
> E.g. any access to /proc/<pid>/fd/<n>.
I figured out which ones I needed to set by rough inspection, always a
dangerous practice.
Thanks!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2002-07-17 0:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-12 20:38 [RFC] Rearranging struct dentry for cache affinity Paul Menage
2002-07-12 20:58 ` Dave Jones
2002-07-12 21:21 ` Paul Menage
2002-07-13 9:11 ` Alexander Viro
2002-07-16 3:54 ` Rusty Russell
2002-07-16 4:40 ` Alexander Viro
2002-07-17 0:04 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020717003135.ACB2D4503@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pmenage@ensim.com \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.