All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Kropelin <akropel1@rochester.rr.com>
To: linux-kernel@vger.kernel.org
Cc: axboe@suse.de
Subject: cpqarray broken since 2.5.19
Date: Sun, 21 Jul 2002 11:28:04 -0400	[thread overview]
Message-ID: <20020721152804.GA6273@www.kroptech.com> (raw)

The cpqarray driver seems to have been broken around 2.5.19 with the
blk_start_queue/blk_stop_queue changes. As-is, cpqarray deadlocks the entire
system when it tries to do partition detection. The bits from the 2.5.19 patch
which seem to relate are:

> @@ -916,6 +915,7 @@
>       goto queue_next;
>
>  startio:
> +     blk_stop_queue(q);
>       start_io(h);
>  }
>
> @@ -1066,8 +1066,8 @@
>       /*
>        * See if we can queue up some more IO
>        */
> -     do_ida_request(BLK_DEFAULT_QUEUE(MAJOR_NR + h->ctlr));
>       spin_unlock_irqrestore(IDA_LOCK(h->ctlr), flags);
> +     blk_start_queue(BLK_DEFAULT_QUEUE(MAJOR_NR + h->ctlr));
>  }
>
>  /*

Simply reverting these changes allows the driver to successfully do partition
detect, but it quickly hangs if any significant amount of I/O is attempted. The
hang in this case seems to just affect processes trying to do I/O on the array;
it is not a whole-system-deadlock.

Test machine is SMP ppro.

--Adam


             reply	other threads:[~2002-07-21 15:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-21 15:28 Adam Kropelin [this message]
2002-07-24 13:39 ` cpqarray broken since 2.5.19 Jens Axboe
2002-07-24 14:07   ` Bartlomiej Zolnierkiewicz
2002-07-24 14:09     ` Jens Axboe
2002-07-24 14:11     ` Marcin Dalecki
2002-07-24 14:19       ` Jens Axboe
2002-07-24 14:41         ` Bartlomiej Zolnierkiewicz
2002-07-24 14:44           ` Jens Axboe
2002-07-24 14:46           ` Marcin Dalecki
2002-07-24 15:15             ` Bartlomiej Zolnierkiewicz
2002-07-24 14:21       ` Bartlomiej Zolnierkiewicz
2002-07-24 14:27         ` Marcin Dalecki
2002-07-24 14:45           ` Bartlomiej Zolnierkiewicz
2002-07-25  0:32   ` Adam Kropelin
2002-07-25 10:39     ` Jens Axboe
2002-07-26  0:30       ` Adam Kropelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020721152804.GA6273@www.kroptech.com \
    --to=akropel1@rochester.rr.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.