From: Jens Axboe <axboe@suse.de>
To: martin@dalecki.de
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
Adam Kropelin <akropel1@rochester.rr.com>,
linux-kernel@vger.kernel.org
Subject: Re: cpqarray broken since 2.5.19
Date: Wed, 24 Jul 2002 16:19:54 +0200 [thread overview]
Message-ID: <20020724141954.GF5159@suse.de> (raw)
In-Reply-To: <3D3EB576.1040601@evision.ag>
On Wed, Jul 24 2002, Marcin Dalecki wrote:
>
> >
> >Jens, the same is in cciss.c.
> >Please remove locking from blk_stop_queue() (as you suggested) or intrduce
> >unlocking in request_functions.
> >
> Bartek I think the removal is just for reassertion that the
> locking is the problem. You can't remove it easly from
> blk_stop_queue() unless you make it mandatory that blk_stop_queue
> has to be run with the lock already held. Or in other words
> basically -> Don't use blk_stop_queue() outside of ->request_fn.
Of couse Bart is advocating just making sure that every caller of
blk_stop_queue() _has_ the queue_lock before calling it, not removing
the locking there.
--
Jens Axboe
next prev parent reply other threads:[~2002-07-24 14:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-21 15:28 cpqarray broken since 2.5.19 Adam Kropelin
2002-07-24 13:39 ` Jens Axboe
2002-07-24 14:07 ` Bartlomiej Zolnierkiewicz
2002-07-24 14:09 ` Jens Axboe
2002-07-24 14:11 ` Marcin Dalecki
2002-07-24 14:19 ` Jens Axboe [this message]
2002-07-24 14:41 ` Bartlomiej Zolnierkiewicz
2002-07-24 14:44 ` Jens Axboe
2002-07-24 14:46 ` Marcin Dalecki
2002-07-24 15:15 ` Bartlomiej Zolnierkiewicz
2002-07-24 14:21 ` Bartlomiej Zolnierkiewicz
2002-07-24 14:27 ` Marcin Dalecki
2002-07-24 14:45 ` Bartlomiej Zolnierkiewicz
2002-07-25 0:32 ` Adam Kropelin
2002-07-25 10:39 ` Jens Axboe
2002-07-26 0:30 ` Adam Kropelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020724141954.GF5159@suse.de \
--to=axboe@suse.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akropel1@rochester.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.