From: Pete Zaitcev <zaitcev@redhat.com>
To: linux-kernel@vger.kernel.org
Subject: Buglet in irq compat code in 2.5.30
Date: Wed, 7 Aug 2002 16:54:43 -0400 [thread overview]
Message-ID: <20020807165443.A3730@devserv.devel.redhat.com> (raw)
The save_flags used to save flags, while local_irq_save saves AND
closes interrupts, and local_irq_save_off simply does not exist.
I did not see anything on the list, perhaps nobody is bold enough
to use 2.5.30?
diff -urN -X dontdiff linux-2.5.30/include/linux/interrupt.h linux-2.5.30-sparc/include/linux/interrupt.h
--- linux-2.5.30/include/linux/interrupt.h Thu Aug 1 14:16:01 2002
+++ linux-2.5.30-sparc/include/linux/interrupt.h Wed Aug 7 13:48:25 2002
@@ -50,9 +50,9 @@
#if !CONFIG_SMP
# define cli() local_irq_disable()
# define sti() local_irq_enable()
-# define save_flags(x) local_irq_save(x)
+# define save_flags(x) local_save_flags(x)
# define restore_flags(x) local_irq_restore(x)
-# define save_and_cli(x) local_irq_save_off(x)
+# define save_and_cli(x) local_irq_save(x)
#endif
next reply other threads:[~2002-08-07 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-07 20:54 Pete Zaitcev [this message]
2002-08-07 20:50 ` Buglet in irq compat code in 2.5.30 David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020807165443.A3730@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.