* Re: Buglet in irq compat code in 2.5.30
2002-08-07 20:54 Buglet in irq compat code in 2.5.30 Pete Zaitcev
@ 2002-08-07 20:50 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2002-08-07 20:50 UTC (permalink / raw)
To: zaitcev; +Cc: linux-kernel
From: Pete Zaitcev <zaitcev@redhat.com>
Date: Wed, 7 Aug 2002 16:54:43 -0400
The save_flags used to save flags, while local_irq_save saves AND
closes interrupts, and local_irq_save_off simply does not exist.
I did not see anything on the list, perhaps nobody is bold enough
to use 2.5.30?
These things really will die very soon, probably best not
to rely on them at all :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Buglet in irq compat code in 2.5.30
@ 2002-08-07 20:54 Pete Zaitcev
2002-08-07 20:50 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pete Zaitcev @ 2002-08-07 20:54 UTC (permalink / raw)
To: linux-kernel
The save_flags used to save flags, while local_irq_save saves AND
closes interrupts, and local_irq_save_off simply does not exist.
I did not see anything on the list, perhaps nobody is bold enough
to use 2.5.30?
diff -urN -X dontdiff linux-2.5.30/include/linux/interrupt.h linux-2.5.30-sparc/include/linux/interrupt.h
--- linux-2.5.30/include/linux/interrupt.h Thu Aug 1 14:16:01 2002
+++ linux-2.5.30-sparc/include/linux/interrupt.h Wed Aug 7 13:48:25 2002
@@ -50,9 +50,9 @@
#if !CONFIG_SMP
# define cli() local_irq_disable()
# define sti() local_irq_enable()
-# define save_flags(x) local_irq_save(x)
+# define save_flags(x) local_save_flags(x)
# define restore_flags(x) local_irq_restore(x)
-# define save_and_cli(x) local_irq_save_off(x)
+# define save_and_cli(x) local_irq_save(x)
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-08-07 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-08-07 20:54 Buglet in irq compat code in 2.5.30 Pete Zaitcev
2002-08-07 20:50 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.