[linux-lvm] /proc/partition problem

[linux-lvm] /proc/partition problem

[kaoru]

Hi,

I reffered to /proc/partitions, a strange character code went 
into a name sequence when I created 26 or more volume of LV(s) 
on 2.4.19 with LVM-1.0.5. 

$ cat /proc/partitions
major minor  #blocks  name

  58     0    3145728 lvma
  58     1    3145728 lvmb
  58     2     512000 lvmc
  58     3     204800 lvmd
.........
  58    24      53248 lvmy
  58    25      53248 lvmz
  58    26      53248 lvm{
  58    27      53248 lvm|
  58    28      53248 lvm}
  58    29      53248 lvm~
  58    30      53248 lvm
  58    31      53248 lvm
  58    32      53248 lvm
  58    33      53248 lvm
  58    34      53248 lvm

I think that this problem is depended on illegal codes of 
a disk_name function(fs/partitions/check.c). 

According to fs/partitions/check.c:

char *disk_name (struct gendisk *hd, int minor, char *buf)
{
.................

        if (part)
                sprintf(buf, "%s%c%d", maj, unit+'a', part);
        else
                sprintf(buf, "%s%c", maj, unit+'a');
        return buf;

}

I think it is better that the LVM staff discuss the fault of 
this code with Linux Kernel code maintainer.

--------
Kaoru

Re: [linux-lvm] /proc/partition problem

[Heinz J . Mauelshagen]

Well, we had support for correct logical volume names ages ago already.
Hasn't been accepted by kernel folks :(

We need to live with 'nasty' names in /proc/partitions, sorry.

On Thu, Aug 15, 2002 at 08:49:44AM +0900, kaoru@bsd.tnes.nec.co.jp wrote:
> Hi,
> 
> I reffered to /proc/partitions, a strange character code went 
> into a name sequence when I created 26 or more volume of LV(s) 
> on 2.4.19 with LVM-1.0.5. 
> 
> $ cat /proc/partitions
> major minor  #blocks  name
> 
>   58     0    3145728 lvma
>   58     1    3145728 lvmb
>   58     2     512000 lvmc
>   58     3     204800 lvmd
> .........
>   58    24      53248 lvmy
>   58    25      53248 lvmz
>   58    26      53248 lvm{
>   58    27      53248 lvm|
>   58    28      53248 lvm}
>   58    29      53248 lvm~
>   58    30      53248 lvm
>   58    31      53248 lvm
>   58    32      53248 lvm
>   58    33      53248 lvm
>   58    34      53248 lvm
> 
> I think that this problem is depended on illegal codes of 
> a disk_name function(fs/partitions/check.c). 
> 
> According to fs/partitions/check.c:
> 
> char *disk_name (struct gendisk *hd, int minor, char *buf)
> {
> .................
> 
>         if (part)
>                 sprintf(buf, "%s%c%d", maj, unit+'a', part);
>         else
>                 sprintf(buf, "%s%c", maj, unit+'a');
>         return buf;
> 
> }
> 
> I think it is better that the LVM staff discuss the fault of 
> this code with Linux Kernel code maintainer.
> 
> --------
> Kaoru
> 
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://www.sistina.com/lvm/Pages/howto.html

-- 

Regards,
Heinz    -- The LVM Guy --

*** Software bugs are stupid.
    Nevertheless it needs not so stupid people to solve them ***

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-lvm] /proc/partition problem

[Luca Berra]

On Fri, Aug 16, 2002 at 12:03:15PM +0200, Heinz J . Mauelshagen wrote:
>
>Well, we had support for correct logical volume names ages ago already.
>Hasn't been accepted by kernel folks :(
>
>We need to live with 'nasty' names in /proc/partitions, sorry.

at least could someone push adding:

        case LVM_MAJOR:
                sprintf(buf, "%s%d", maj, unit);
                return buf;

it would at lest be accettable

btw
it should also be needed for device-mapper

-- 
Luca Berra -- bluca@comedia.it
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \

Re: [linux-lvm] /proc/partition problem

[Joe Thornber]

On Fri, Aug 16, 2002 at 12:58:21PM +0200, Luca Berra wrote:
> btw
> it should also be needed for device-mapper

No, device-mapper maps *block devices* to produce logical *block
devices*.  I'm not perpetuating this genhd/partition crap.

- Joe