* 2.4.20-pre4 + LVM = hosed /proc/partitions
@ 2002-08-21 2:27 Erik Andersen
2002-08-21 3:04 ` Erik Andersen
0 siblings, 1 reply; 6+ messages in thread
From: Erik Andersen @ 2002-08-21 2:27 UTC (permalink / raw)
To: linux-kernel
Try compiling CONFIG_BLK_DEV_LVM into 2.4.20-pre4 and then run
'cat /proc/partitions' for some amusement. I really like the way
it prints /dev/lvmX, where X is first a-z, and then proceeds to
apparently increment X another 229 times...
$ cat /proc/partitions | wc -l
259
And /proc/partitions now contains only LVM entries...
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: 2.4.20-pre4 + LVM = hosed /proc/partitions
2002-08-21 2:27 2.4.20-pre4 + LVM = hosed /proc/partitions Erik Andersen
@ 2002-08-21 3:04 ` Erik Andersen
2002-08-21 3:21 ` Jeff Chua
2002-08-21 13:45 ` Alan Cox
0 siblings, 2 replies; 6+ messages in thread
From: Erik Andersen @ 2002-08-21 3:04 UTC (permalink / raw)
To: linux-kernel
On Tue Aug 20, 2002 at 08:27:32PM -0600, Erik wrote:
> Try compiling CONFIG_BLK_DEV_LVM into 2.4.20-pre4 and then run
> 'cat /proc/partitions' for some amusement. I really like the way
It also seems to occur for md and ataraid.
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.4.20-pre4 + LVM = hosed /proc/partitions
2002-08-21 3:04 ` Erik Andersen
@ 2002-08-21 3:21 ` Jeff Chua
2002-08-21 3:26 ` Erik Andersen
2002-08-21 13:45 ` Alan Cox
1 sibling, 1 reply; 6+ messages in thread
From: Jeff Chua @ 2002-08-21 3:21 UTC (permalink / raw)
To: Erik Andersen; +Cc: linux-kernel
On Tue, 20 Aug 2002, Erik Andersen wrote:
> On Tue Aug 20, 2002 at 08:27:32PM -0600, Erik wrote:
> > Try compiling CONFIG_BLK_DEV_LVM into 2.4.20-pre4 and then run
> > 'cat /proc/partitions' for some amusement. I really like the way
>
> It also seems to occur for md and ataraid.
You should consider switching to LVM2. LVM2 doesn't have such problem, and
it seems more stable too.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.4.20-pre4 + LVM = hosed /proc/partitions
2002-08-21 3:21 ` Jeff Chua
@ 2002-08-21 3:26 ` Erik Andersen
0 siblings, 0 replies; 6+ messages in thread
From: Erik Andersen @ 2002-08-21 3:26 UTC (permalink / raw)
To: Jeff Chua; +Cc: linux-kernel
On Wed Aug 21, 2002 at 11:21:04AM +0800, Jeff Chua wrote:
>
> On Tue, 20 Aug 2002, Erik Andersen wrote:
>
> > On Tue Aug 20, 2002 at 08:27:32PM -0600, Erik wrote:
> > > Try compiling CONFIG_BLK_DEV_LVM into 2.4.20-pre4 and then run
> > > 'cat /proc/partitions' for some amusement. I really like the way
> >
> > It also seems to occur for md and ataraid.
>
> You should consider switching to LVM2. LVM2 doesn't have such problem, and
> it seems more stable too.
I'm not actually using it. Just compiled it in and saw wierd
stuff happening...
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.4.20-pre4 + LVM = hosed /proc/partitions
2002-08-21 3:04 ` Erik Andersen
2002-08-21 3:21 ` Jeff Chua
@ 2002-08-21 13:45 ` Alan Cox
2002-08-21 14:06 ` [PATCH] 2.4.20-pre[234] hosed /proc/partitions fix Erik Andersen
1 sibling, 1 reply; 6+ messages in thread
From: Alan Cox @ 2002-08-21 13:45 UTC (permalink / raw)
To: andersen; +Cc: linux-kernel
On Wed, 2002-08-21 at 04:04, Erik Andersen wrote:
> On Tue Aug 20, 2002 at 08:27:32PM -0600, Erik wrote:
> > Try compiling CONFIG_BLK_DEV_LVM into 2.4.20-pre4 and then run
> > 'cat /proc/partitions' for some amusement. I really like the way
>
> It also seems to occur for md and ataraid.
Fixed in -ac for a while - not had time to do another sync with Marcelo
though
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] 2.4.20-pre[234] hosed /proc/partitions fix
2002-08-21 13:45 ` Alan Cox
@ 2002-08-21 14:06 ` Erik Andersen
0 siblings, 0 replies; 6+ messages in thread
From: Erik Andersen @ 2002-08-21 14:06 UTC (permalink / raw)
To: Alan Cox, Marcelo Tosatti; +Cc: linux-kernel
On Wed Aug 21, 2002 at 02:45:06PM +0100, Alan Cox wrote:
> On Wed, 2002-08-21 at 04:04, Erik Andersen wrote:
> > On Tue Aug 20, 2002 at 08:27:32PM -0600, Erik wrote:
> > > Try compiling CONFIG_BLK_DEV_LVM into 2.4.20-pre4 and then run
> > > 'cat /proc/partitions' for some amusement. I really like the way
> >
> > It also seems to occur for md and ataraid.
>
> Fixed in -ac for a while - not had time to do another sync with Marcelo
> though
Sigh. I wished I'd known an hour ago, since it would have
saved me the bother of figuring it out myself.
Marcello,
Please apply the following patch to 2.4.20-pre5. The
patch that went into -pre2 had a nasty bug in it that
causes /proc/partitions to behave very badly. This
patch restores it to sanity.
--- drivers/block/genhd.c.orig Wed Aug 21 07:51:21 2002
+++ drivers/block/genhd.c Wed Aug 21 08:03:48 2002
@@ -194,9 +194,7 @@
/* show the full disk and all non-0 size partitions of it */
for (n = 0; n < (gp->nr_real << gp->minor_shift); n++) {
- int mask = (1<<gp->minor_shift) - 1;
-
- if (!(n & mask) || gp->part[n].nr_sects) {
+ if (gp->part[n].nr_sects) {
#ifdef CONFIG_BLK_STATS
struct hd_struct *hd = &gp->part[n];
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-08-21 14:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-08-21 2:27 2.4.20-pre4 + LVM = hosed /proc/partitions Erik Andersen
2002-08-21 3:04 ` Erik Andersen
2002-08-21 3:21 ` Jeff Chua
2002-08-21 3:26 ` Erik Andersen
2002-08-21 13:45 ` Alan Cox
2002-08-21 14:06 ` [PATCH] 2.4.20-pre[234] hosed /proc/partitions fix Erik Andersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.