[PATCH TRIVIAL]: repost 2.4.19/drivers/atm/iphase.c

[PATCH TRIVIAL]: repost 2.4.19/drivers/atm/iphase.c

[silvio]

[-- Attachment #1: Type: text/plain, Size: 74 bytes --]

i must be on drugs.. forgot to attach patch! (of like 1 line!)

--
Silvio

[-- Attachment #2: patch.linux3 --]
[-- Type: text/plain, Size: 653 bytes --]

--- linux-2.4.19/drivers/atm/iphase.c	Mon Feb 25 11:37:57 2002
+++ linux-2.4.19-dev/drivers/atm/iphase.c	Sat Aug 24 02:44:15 2002
@@ -1990,6 +1990,7 @@
             printk(KERN_ERR DEV_LABEL " couldn't get mem\n");
             return -EAGAIN;
         }
+/* XXX: memory leak on failure */
        	for (i= 0; i< iadev->num_tx_desc; i++)
        	{
  
@@ -2002,6 +2003,7 @@
         }
         iadev->desc_tbl = kmalloc(iadev->num_tx_desc *
                                    sizeof(struct desc_tbl_t), GFP_KERNEL);
+	if (iadev->desc_tbl == NULL) return -EAGAIN;
   
 	/* Communication Queues base address */  
         i = TX_COMP_Q * iadev->memSize;

Re: [PATCH TRIVIAL]: repost 2.4.19/drivers/atm/iphase.c

[Francois Romieu]

silvio@qualys.com <silvio@qualys.com> :
> i must be on drugs.. forgot to attach patch! (of like 1 line!)
> 
> --
> Silvio

I have patches for iphase driver at 
http://www.cogenit.fr/linux/patches/2.5.25/. As there are no more
holidays scheduled, they'll be tested shortly.

-- 
Ueimor

Re: [PATCH TRIVIAL]: repost 2.4.19/drivers/atm/iphase.c

[Bernd Eckenfels]

In article <20020824030855.A2399@hamsec.aurora.sfo.interquest.net> you wrote:
> +       if (iadev->desc_tbl == NULL) return -EAGAIN;

is there a pattern in your patches? EAGAIN or ENOMEM?

Greetings
Bernd