From: Dave Jones <davej@suse.de>
To: Thunder from the hill <thunder@lightweight.ods.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
junio@siamese.dyndns.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [TRIVIAL] strlen("literal string") -> (sizeof("literal string")-1)
Date: Thu, 29 Aug 2002 17:48:45 +0200 [thread overview]
Message-ID: <20020829174845.G17887@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0208290938180.3234-100000@hawkeye.luckynet.adm>; from thunder@lightweight.ods.org on Thu, Aug 29, 2002 at 09:39:14AM -0600
On Thu, Aug 29, 2002 at 09:39:14AM -0600, Thunder from the hill wrote:
> > #define strlen(x) \
> > (__builtin_constant_p(x) && sizeof(x) != sizeof(char *)
> > ? (sizeof(x) - 1) : __strlen(x))
>
> I must say that doesn't make the code any cleaner, which leads to it being
> not as clean as Keith suggested. It was a code cleanup, not a code messup.
Sure the macro is fugly, but the code that uses it becomes
cleaner which was the whole point here.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-08-29 15:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.lrmcokv.1q28k2s@ifi.uio.no>
[not found] ` <fa.pm2g4iv.k0s9jg@ifi.uio.no>
2002-08-29 0:49 ` [TRIVIAL] strlen("literal string") -> (sizeof("literal string")-1) junio
2002-08-29 3:15 ` Rusty Russell
2002-08-29 15:39 ` Thunder from the hill
2002-08-29 15:48 ` Dave Jones [this message]
2002-08-30 3:50 ` Rusty Russell
[not found] <20020829031008.T7920@devserv.devel.redhat.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.44.0208290955280.2070-100000@home.transmeta.com.suse.lists.linux.kernel>
2002-08-29 17:23 ` Andi Kleen
2002-08-29 17:51 ` Alexander Viro
2002-08-29 17:53 ` Andi Kleen
[not found] <fa.iks3ohv.1flge08@ifi.uio.no>
2002-08-28 21:31 ` junkio
2002-08-28 21:55 ` Jim Treadway
2002-08-29 3:09 ` Rusty Russell
2002-08-29 3:26 ` Daniel Jacobowitz
2002-08-29 6:29 ` Rusty Russell
2002-08-29 7:10 ` Jakub Jelinek
2002-08-29 16:56 ` Linus Torvalds
2002-08-29 20:38 ` Denis Zaitsev
2002-09-06 12:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020829174845.G17887@suse.de \
--to=davej@suse.de \
--cc=junio@siamese.dyndns.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=thunder@lightweight.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.