From: Patrick Schaaf <bof@bof.de>
To: Andi Kleen <ak@suse.de>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Martin Wilck <Martin.Wilck@Fujitsu-Siemens.com>,
Harald Welte <laforge@gnumonks.org>,
Netfilter Mailing List <netfilter-devel@lists.netfilter.org>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
Patrick Schaaf <bof@bof.de>
Subject: Re: ip_conntrack_hash() problem
Date: Thu, 5 Sep 2002 19:55:47 +0200 [thread overview]
Message-ID: <20020905195547.A21899@oknodo.bof.de> (raw)
In-Reply-To: <20020905135440.A10805@wotan.suse.de>; from ak@suse.de on Thu, Sep 05, 2002 at 01:54:40PM +0200
On Thu, Sep 05, 2002 at 01:54:40PM +0200, Andi Kleen wrote:
> > I'll feed this through 2.5, once it's had some more testing (hint
> > hint!). Then Harald will make a call on 2.4.
>
> I would propose to include Martin's simple patch as a short term fix
> for 2.4 until Rusty's full work can get in. It fixes an bad performance
> problems in some not too uncommon cases.
As a short time fix, seeing that it's mostly even hash bucket counts
that give a problem, I would still propose just making the bucket count
the nearest odd number, i.e. basically htable_size |= 1 in the startup code.
I don't expect any user to notice such a miniscule change.
best regards
Patrick
next prev parent reply other threads:[~2002-09-05 17:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-04 12:33 ip_conntrack_hash() problem Martin Wilck
2002-09-04 12:56 ` Harald Welte
2002-09-04 13:24 ` Martin Wilck
2002-09-04 13:26 ` Andi Kleen
2002-09-05 0:39 ` Rusty Russell
2002-09-05 6:21 ` Patrick Schaaf
2002-09-05 6:24 ` David S. Miller
2002-09-05 6:33 ` Patrick Schaaf
2002-09-05 6:32 ` David S. Miller
2002-09-05 6:39 ` Patrick Schaaf
2002-09-05 6:40 ` David S. Miller
2002-09-05 13:37 ` Rik van Riel
2002-09-05 6:32 ` David S. Miller
2002-09-05 11:14 ` Rusty Russell
2002-09-05 6:51 ` Patrick Schaaf
2002-09-05 7:19 ` Martin Wilck
2002-09-05 11:15 ` Rusty Russell
2002-09-05 11:54 ` Andi Kleen
2002-09-05 17:55 ` Patrick Schaaf [this message]
2002-09-05 18:24 ` Martin Wilck
2002-10-11 3:51 ` Zheng Weibin
2002-09-05 8:19 ` Harald Welte
2002-09-04 13:40 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020905195547.A21899@oknodo.bof.de \
--to=bof@bof.de \
--cc=Martin.Wilck@Fujitsu-Siemens.com \
--cc=ak@suse.de \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.