[PATCH] Fix ACPI IRQ level weirdness

[PATCH] Fix ACPI IRQ level weirdness

[Andy Grover]

Hi Linus,

Could you please give this patch a go, and if it works, please apply?

This patch aborts the setting of the ACPI interrupt's level and trigger to
what we think it should be if there is an interrupt source override for
it.

Regards -- Andy

===== arch/i386/kernel/mpparse.c 1.20 vs edited =====
--- 1.20/arch/i386/kernel/mpparse.c	Thu Sep 19 18:14:32 2002
+++ edited/arch/i386/kernel/mpparse.c	Thu Sep 26 14:04:03 2002
@@ -1019,10 +1019,39 @@
 
 /* Ensure the ACPI SCI interrupt level is active low, edge-triggered */
 
+extern FADT_DESCRIPTOR acpi_fadt;
+
 void __init mp_config_ioapic_for_sci(int irq)
 {
 	int ioapic;
 	int ioapic_pin;
+	struct acpi_table_madt *madt;
+	struct acpi_table_int_src_ovr *entry = NULL;
+	void *madt_end;
+	acpi_status status;
+
+	/*
+	 * Ensure that if there is an interrupt source override entry
+	 * for the ACPI SCI, we leave it as is. Unfortunately this involves
+	 * walking the MADT again.
+	 */
+	status = acpi_get_firmware_table("APIC", 1, ACPI_LOGICAL_ADDRESSING,
+		(acpi_table_header **) &madt);
+	if (ACPI_SUCCESS(status)) {
+		madt_end = madt + madt->header.length;
+
+		entry = (struct acpi_table_int_src_ovr *)
+                ((unsigned long) madt + sizeof(struct acpi_table_madt));
+
+		while ((void *) entry < madt_end) {
+                	if (entry->header.type == ACPI_MADT_INT_SRC_OVR &&
+			    acpi_fadt.sci_int == entry->global_irq)
+                		return;
+
+                	entry = (struct acpi_table_int_src_ovr *)
+                	        ((unsigned long) entry + entry->header.length);
+        	}
+	}
 
 	ioapic = mp_find_ioapic(irq);
 



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [PATCH] Fix ACPI IRQ level weirdness

[Linus Torvalds]

On Thu, 26 Sep 2002, Andy Grover wrote:
> 
> Could you please give this patch a go, and if it works, please apply?

Seems to fix it for me:

  9:          0          0          0          0   IO-APIC-level  acpi

which is a bit of a change.

		Linus



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [PATCH] Fix ACPI IRQ level weirdness

[Jamin W. Collins]

On Thu, Sep 26, 2002 at 02:17:08PM -0700, Andy Grover wrote:

> Could you please give this patch a go, and if it works, please apply?

No change in my situation.  Still have a large number of interrupt hits
when ASD is running in conjunction with ACPI that I don't have when it
is run without ACPI.

-- 
Jamin W. Collins


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [PATCH] Fix ACPI IRQ level weirdness

[Hiromichi Ito]

Hi,

I am using 2.4.20-pre7 with acpi-20020918 patch and had become the same phenomenon.

I am using Xeon(enable HT) and E7500 chipset system [Supermicro P4DP8-G2].

>Could you please give this patch a go, and if it works, please apply?

Your patch works fine.
It stopped the phenomenon.

# Lance Inc.                R&D Division # 
# Hiromichi Ito  (itooon-ez3K6K0nqN9BPp5YB5Ev3w@public.gmane.org) #


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf