All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <ak@muc.de>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use __attribute__((malloc)) for gcc 3.2
Date: Sun, 29 Sep 2002 18:26:43 +0100	[thread overview]
Message-ID: <20020929182643.C8564@infradead.org> (raw)
In-Reply-To: <20020929152731.GA10631@averell>; from ak@muc.de on Sun, Sep 29, 2002 at 05:27:31PM +0200

On Sun, Sep 29, 2002 at 05:27:31PM +0200, Andi Kleen wrote:
> -extern pgd_t *pgd_alloc(struct mm_struct *);
> +extern pgd_t *pgd_alloc(struct mm_struct *) malloc_function;

Anz chance you could make that __malloc?  That how the other
atrributes in the kernel (e.g. __init/__exit) work.

> +/* Function allocates new memory and return cannot alias with anything */
> +#define malloc_function __attribute__((malloc))
> +/* Never inline */
> +#define noinline __attribute__((noinline))
> +#else
> +#define malloc_function
> +#define noinline
> +#endif

Dito for __noinline?  And IMHO compiler.h is the better place for this.

BTW, do you have any stats on the better optimization?

  parent reply	other threads:[~2002-09-29 17:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-29 15:27 [PATCH] Use __attribute__((malloc)) for gcc 3.2 Andi Kleen
2002-09-29 16:24 ` Adrian Bunk
2002-09-29 17:26 ` Christoph Hellwig [this message]
2002-09-30  0:11   ` David S. Miller
2002-09-30  0:29     ` Andi Kleen
2002-09-29 20:01 ` Jakub Jelinek
2002-09-30  0:04   ` Andi Kleen
2002-10-07 10:05   ` Richard Henderson
2002-10-07 10:29     ` David S. Miller
2002-10-07 10:56       ` Andi Kleen
2002-10-07 11:07         ` Arjan van de Ven
2002-10-07 11:45         ` Richard Henderson
2002-10-07 12:27           ` Andi Kleen
2002-09-29 23:51 ` Anton Blanchard
2002-09-30  0:31   ` Andi Kleen
2002-09-30  1:07     ` Daniel Jacobowitz
2002-10-02 13:46     ` Pavel Machek
     [not found] <20020929152731.GA10631@averell.suse.lists.linux.kernel>
     [not found] ` <20020929182643.C8564@infradead.org.suse.lists.linux.kernel>
2002-09-29 19:09   ` Andi Kleen
2002-09-29 20:20     ` Adrian Bunk
2002-09-30  0:21     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020929182643.C8564@infradead.org \
    --to=hch@infradead.org \
    --cc=ak@muc.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.