[2.5 patch] fix kbuild breakage in drivers/atm

[2.5 patch] fix kbuild breakage in drivers/atm

[Adrian Bunk]

The kbuild changes in 2.5.41 caused the following compile error in
drivers/atm:

<--  snip  -->

...
make[2]: *** No rule to make target `pca200e_ecd.bin2', needed by
`drivers/atm/fore200e_pca_fw.c'.  Stop.
make[1]: *** [drivers/atm] Error 2

<--  snip  -->


The following patch fixes it:


--- linux-2.5.41-notac-full/drivers/atm/Makefile.old	2002-10-08 17:48:26.000000000 +0200
+++ linux-2.5.41-notac-full/drivers/atm/Makefile	2002-10-08 17:50:45.000000000 +0200
@@ -37,7 +37,7 @@
   endif
   ifeq ($(CONFIG_ATM_FORE200E_PCA_DEFAULT_FW),y)
 #   guess the target endianess to choose the right PCA-200E firmware image
-    CONFIG_ATM_FORE200E_PCA_FW := $(shell if test -n "`$(CC) -E -dM ../../include/asm/byteorder.h | grep ' __LITTLE_ENDIAN '`"; then echo pca200e.bin; else echo pca200e_ecd.bin2; fi)
+    CONFIG_ATM_FORE200E_PCA_FW := $(shell if test -n "`$(CC) -E -dM include/asm/byteorder.h | grep ' __LITTLE_ENDIAN '`"; then echo drivers/atm/pca200e.bin; else echo drivers/atm/pca200e_ecd.bin2; fi)
   endif
 endif
 ifeq ($(CONFIG_ATM_FORE200E_SBA),y)





cu
Adrian

BTW:
There might be places in the kernel that are now broken without a compile
error, consider the second part of this line would output a compiler flag
instead of a file name.

Re: [2.5 patch] fix kbuild breakage in drivers/atm

[Sam Ravnborg]

On Tue, Oct 08, 2002 at 06:02:41PM +0200, Adrian Bunk wrote:
> BTW:
> There might be places in the kernel that are now broken without a compile
> error, consider the second part of this line would output a compiler flag
> instead of a file name.

find -name Makefile | cut -d: -f 1 | grep -v arch | xargs grep '\.\./'

./drivers/atm/Makefile:    CONFIG_ATM_FORE200E_PCA_FW := $(shell if test -n "`$(CC) -E -dM ../../include/asm/byteorder.h | grep ' __LITTLE_ENDIAN '`"; then echo pca200e.bin; else echo pca200e_ecd.bin2; fi)
./drivers/net/Makefile:obj-$(CONFIG_ARCH_ACORN) += ../acorn/net/
./drivers/scsi/Makefile:obj-$(CONFIG_ARCH_ACORN)	+= ../acorn/scsi/
./fs/devfs/Makefile:TOPDIR = ../..
./fs/devfs/Makefile:	gcc -o /tmp/base.o -D__KERNEL__ -I../../include -Wall \

Dunno about the acorn part, but devfs looks broken.
Checking, devfs makefile has some documentation support in the makefile.
I'm tempted to delete it, surely it's not part of the kernel build system,
but I guess someone would yell at me.

If we include the architecture Makefiles:
find -name Makefile |  xargs grep '\.\./' | wc -l
   148

But I'm sure we hit a lot of false positves here.

	Sam

Re: [2.5 patch] fix kbuild breakage in drivers/atm

[Russell King]

On Tue, Oct 08, 2002 at 07:49:46PM +0200, Sam Ravnborg wrote:
> find -name Makefile | cut -d: -f 1 | grep -v arch | xargs grep '\.\./'
> 
> ./drivers/atm/Makefile:    CONFIG_ATM_FORE200E_PCA_FW := $(shell if test -n "`$(CC) -E -dM ../../include/asm/byteorder.h | grep ' __LITTLE_ENDIAN '`"; then echo pca200e.bin; else echo pca200e_ecd.bin2; fi)
> ./drivers/net/Makefile:obj-$(CONFIG_ARCH_ACORN) += ../acorn/net/
> ./drivers/scsi/Makefile:obj-$(CONFIG_ARCH_ACORN)	+= ../acorn/scsi/
> ./fs/devfs/Makefile:TOPDIR = ../..
> ./fs/devfs/Makefile:	gcc -o /tmp/base.o -D__KERNEL__ -I../../include -Wall \
> 
> Dunno about the acorn part, but devfs looks broken.

I'd love for the acorn ones to go away, but certainly the SCSI one is
needed to get things to happen in the right order (or last time I
tested it which was quite some while ago, scsi still required a specific
init ordering.)

Whatever happens, I'll see about fixing them up once I've caught up with
2.5.41.  Other stuff is taking a back seat while I finish cleaning up
2.5.40 for the ARM people (a fair amount of crap has accumulated since
my previous 2.5.30 release, and those who normally follow what I do will
realise that there's been a very long silence, some would say too long...)

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html