patch for linux/usb.h

patch for linux/usb.h

[Wiktor Wodecki]

[-- Attachment #1: Type: text/plain, Size: 100 bytes --]

hi there,

missing urb_t typedef

-- 
Regards,

Wiktor Wodecki      |    http://johoho.eggheads.org

[-- Attachment #2: usb_patch --]
[-- Type: text/plain, Size: 446 bytes --]

diff -bur linux/include/linux/usb.h linux-2.4.20-pre9.kirk/include/linux/usb.h
--- linux/include/linux/usb.h	2002-10-18 22:56:49.000000000 +0200
+++ linux-2.4.20-pre9.kirk/include/linux/usb.h	2002-10-18 23:15:35.000000000 +0200
@@ -525,7 +525,7 @@
 	usb_complete_t complete;	// pointer to completion routine
 	//
 	struct iso_packet_descriptor iso_frame_desc[0];
+} urb_t;
-};
 
 /**
  * FILL_CONTROL_URB - macro to help initialize a control urb

Re: patch for linux/usb.h

[Greg KH]

On Fri, Oct 18, 2002 at 11:25:32PM +0200, Wiktor Wodecki wrote:
> +} urb_t;
> -};

Heh, you're kidding me, right?

No, that's not "missing" it was taken out because it should have never
gotten there in the first place.

thanks,

greg k-h

Re: patch for linux/usb.h

[Wiktor Wodecki]

> > +} urb_t;
> > -};
> 
> No, that's not "missing" it was taken out because it should have never
> gotten there in the first place.

hmmm, it might "not be a good thing" to change an interface in a stable
kernel series. this, for example, broke my quickcam express video cam
driver. It might be wrong there, however I think we should leave it
there...not apply this to 2.5 then

-- 
Regards,

Wiktor Wodecki      |    http://johoho.eggheads.org

Re: patch for linux/usb.h

[Greg KH]

On Fri, Oct 18, 2002 at 11:45:19PM +0200, Wiktor Wodecki wrote:
> > > +} urb_t;
> > > -};
> > 
> > No, that's not "missing" it was taken out because it should have never
> > gotten there in the first place.
> 
> hmmm, it might "not be a good thing" to change an interface in a stable
> kernel series. this, for example, broke my quickcam express video cam
> driver. It might be wrong there, however I think we should leave it
> there...not apply this to 2.5 then

Sorry, but I fixed up all in-kernel instances of this usage.  If you
want to keep a driver outside of the main kernel tree, you're going to
have to get used to things like this.  In fact, this is a very minor
change, wait until some of the other USB API changes that have happened
in 2.5 get backported to 2.4 :)

Good luck,

greg k-h