[2.5 patch] don't #include tqueue.h in drivers/net/wan/cycx_main.c

[2.5 patch] don't #include tqueue.h in drivers/net/wan/cycx_main.c

[Adrian Bunk]

There's the following compile error in 2.5.44:

<--  snip  -->

...
  gcc -Wp,-MD,drivers/net/wan/.cycx_main.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-Iarch/i386/mach-generic -nostdinc -iwithprefix include    -DKBUILD_BASENAME=cycx_main   -c -o
drivers/net/wan/cycx_main.o drivers/net/wan/cycx_main.c
drivers/net/wan/cycx_main.c:47: linux/tqueue.h: No such file or directory
make[3]: *** [drivers/net/wan/cycx_main.o] Error 1

<--  snip  -->


With the following trivial patch it compiles without errors or warnings:


--- linux-2.5.44-full/drivers/net/wan/cycx_main.c.old	2002-10-20 16:20:02.000000000 +0200
+++ linux-2.5.44-full/drivers/net/wan/cycx_main.c	2002-10-20 16:20:25.000000000 +0200
@@ -44,7 +44,6 @@
 #include <linux/kernel.h>	/* printk(), and other useful stuff */
 #include <linux/module.h>	/* support for loadable modules */
 #include <linux/ioport.h>	/* request_region(), release_region() */
-#include <linux/tqueue.h>	/* for kernel task queues */
 #include <linux/wanrouter.h>	/* WAN router definitions */
 #include <linux/cyclomx.h>	/* cyclomx common user API definitions */
 #include <asm/uaccess.h>	/* kernel <-> user copy */


cu
Adrian

-- 

               "Is there not promise of rain?" Ling Tan asked suddenly out
                of the darkness. There had been need of rain for many days.
               "Only a promise," Lao Er said.
                                               Pearl S. Buck - Dragon Seed

Re: [2.5 patch] don't #include tqueue.h in drivers/net/wan/cycx_main.c

[Martin Waitz]

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

hi :)

On Sun, Oct 20, 2002 at 04:37:49PM +0200, Adrian Bunk wrote:
> -#include <linux/tqueue.h>	/* for kernel task queues */

that is not the only file still including tqueue.h:

./drivers/acorn/block/mfmhd.c:#include <linux/tqueue.h>
./drivers/char/dz.c:#include <linux/tqueue.h>
./drivers/char/specialix.c:#include <linux/tqueue.h>
./drivers/char/vme_scc.c:#include <linux/tqueue.h>
./drivers/ieee1394/ieee1394_types.h:#include <linux/tqueue.h>
./drivers/macintosh/adb.c:#include <linux/tqueue.h>
./drivers/media/video/planb.c:#include <linux/tqueue.h>
./drivers/message/fusion/mptlan.h:#include <linux/tqueue.h>
./drivers/net/wan/cycx_main.c:#include <linux/tqueue.h>
./drivers/s390/net/lcs.c:#include <linux/tqueue.h>
./drivers/sbus/char/aurora.c:#include <linux/tqueue.h>
./drivers/scsi/pcmcia/nsp_cs.c:#include <linux/tqueue.h>
./drivers/scsi/mesh.c:#include <linux/tqueue.h>


-- 
CU,		  / Friedrich-Alexander University Erlangen, Germany
Martin Waitz	//  [Tali on IRCnet]  [tali.home.pages.de] _________
______________/// - - - - - - - - - - - - - - - - - - - - ///
dies ist eine manuell generierte mail, sie beinhaltet    //
tippfehler und ist auch ohne grossbuchstaben gueltig.   /
			    -
Wer bereit ist, grundlegende Freiheiten aufzugeben, um sich 
kurzfristige Sicherheit zu verschaffen, der hat weder Freiheit 
noch Sicherheit verdient.
			Benjamin Franklin  (1706 - 1790)

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]