All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: Grant Grundler <grundler@dsl2.external.hp.com>
Cc: parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] rp2470 hang...getting closer
Date: Mon, 21 Oct 2002 15:59:32 +0100	[thread overview]
Message-ID: <20021021155932.L5285@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20021013044033.88A544829@dsl2.external.hp.com>; from grundler@dsl2.external.hp.com on Sat, Oct 12, 2002 at 10:40:33PM -0600

On Sat, Oct 12, 2002 at 10:40:33PM -0600, Grant Grundler wrote:
> The problem is we shouldn't see *any* interrupts, not even timers.
> scsi_register_host() used spin_lock_irqsave() to acquire io_request_lock.
> Either someone is clobbering the irqsave or it's being ignored.
> That's the part the still needs to be worked out.

I wonder if this is interesting:

void handle_interruption(int code, struct pt_regs *regs)
{
        unsigned long fault_address = 0;
        unsigned long fault_space = 0;
        struct siginfo si;

        if (code == 1)
            pdc_console_restart();  /* switch back to pdc if HPMC */
        else
            sti();

so if we take, say, a page fault, we reenable interrupts on all CPUs.
Who the hell put this code in there?!

Thanks to Thibaut for finding this particular excrescence during
CONFIG_SMP frobbing on 2.5.  I'm not sure what this should be changed to.
local_irq_enable?  Do we want interrupts enabled at this point?

-- 
Revolutions do not require corporate support.

  parent reply	other threads:[~2002-10-21 14:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-13  4:40 [parisc-linux] rp2470 hang...getting closer Grant Grundler
2002-10-13 13:56 ` Thibaut VARENE
2002-10-21  0:57 ` Grant Grundler
2002-10-21  2:21   ` Matthew Wilcox
2002-10-21  3:33     ` Grant Grundler
2002-10-21 14:59 ` Matthew Wilcox [this message]
2002-10-21 15:26   ` Matthew Wilcox
2002-10-21 21:58     ` Grant Grundler
  -- strict thread matches above, loose matches on Subject: below --
2002-10-22  0:41 John Marvin
2002-10-23  1:19 ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021021155932.L5285@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=grundler@dsl2.external.hp.com \
    --cc=parisc-linux@lists.parisc-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.