From: Matthew Wilcox <willy@debian.org>
To: Matthew Wilcox <willy@debian.org>
Cc: Grant Grundler <grundler@dsl2.external.hp.com>,
parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] rp2470 hang...getting closer
Date: Mon, 21 Oct 2002 16:26:26 +0100 [thread overview]
Message-ID: <20021021162626.A1356@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20021021155932.L5285@parcelfarce.linux.theplanet.co.uk>; from willy@debian.org on Mon, Oct 21, 2002 at 03:59:32PM +0100
On Mon, Oct 21, 2002 at 03:59:32PM +0100, Matthew Wilcox wrote:
> so if we take, say, a page fault, we reenable interrupts on all CPUs.
> Who the hell put this code in there?!
>
> Thanks to Thibaut for finding this particular excrescence during
> CONFIG_SMP frobbing on 2.5. I'm not sure what this should be changed to.
> local_irq_enable? Do we want interrupts enabled at this point?
ok, going back through the CVS logs finds the answer:
http://cvs.parisc-linux.org/obsolete/linux-2.3/arch/parisc/kernel/traps.c#rev1.9
Revision 1.9 / (as text) / (view) - annotate - [select for diffs] , Tue Feb 15 17:02:03 2000 UTC (2 years, 8 months ago) by jsm
Branch: MAIN
Changes since 1.8: +11 -2 lines
Diff to previous 1.8
Enable interrupts in fault path. Trap kernel space faults.
So I think we want to change the sti() call to local_irq_enable().
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2002-10-21 15:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-13 4:40 [parisc-linux] rp2470 hang...getting closer Grant Grundler
2002-10-13 13:56 ` Thibaut VARENE
2002-10-21 0:57 ` Grant Grundler
2002-10-21 2:21 ` Matthew Wilcox
2002-10-21 3:33 ` Grant Grundler
2002-10-21 14:59 ` Matthew Wilcox
2002-10-21 15:26 ` Matthew Wilcox [this message]
2002-10-21 21:58 ` Grant Grundler
-- strict thread matches above, loose matches on Subject: below --
2002-10-22 0:41 John Marvin
2002-10-23 1:19 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021021162626.A1356@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=grundler@dsl2.external.hp.com \
--cc=parisc-linux@lists.parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.