[Patch] 2.5.44 Stop bttv_driver.c from flooding /var/log/messages

[Patch] 2.5.44 Stop bttv_driver.c from flooding /var/log/messages

[Bongani]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

Hi Alan

I have sent this patch to Gerd and I did not get any reply from him, so...
The bttv drivers are/were filling up my /var/log/messages file with the
following output

Oct 20 04:03:01 localhost kernel: bttv0: amux: mode=-1 audio=1 signal=no 
mux=4/1 irq=yes
Oct 20 04:03:01 localhost kernel: bttv0: amux: mode=-1 audio=1 signal=yes 
mux=1/1 irq=yes
Oct 20 04:03:08 localhost kernel: bttv0: amux: mode=-1 audio=1 signal=no 
mux=4/1 irq=yes

(Which seems to repeat three times a second for three seconds and waits 7 
second before printing the message again)

The following patch quites them down.

Thanx

[-- Attachment #2: bttv.patch --]
[-- Type: text/x-diff, Size: 610 bytes --]

--- linux-2.5/drivers/media/video/bttv-driver.c.old	2002-10-21 00:08:50.000000000 +0200
+++ linux-2.5/drivers/media/video/bttv-driver.c	2002-10-21 00:09:17.000000000 +0200
@@ -813,7 +813,7 @@
 	i2c_mux = mux = (btv->audio & AUDIO_MUTE) ? AUDIO_OFF : btv->audio;
 	if (btv->opt_automute && !signal && !btv->radio_user)
 		mux = AUDIO_OFF;
-	printk("bttv%d: amux: mode=%d audio=%d signal=%s mux=%d/%d irq=%s\n",
+	dprintk(KERN_DEBUG "bttv%d: amux: mode=%d audio=%d signal=%s mux=%d/%d irq=%s\n",
 	       btv->nr, mode, btv->audio, signal ? "yes" : "no",
 	       mux, i2c_mux, in_interrupt() ? "yes" : "no");
 

Re: [Patch] 2.5.44 Stop bttv_driver.c from flooding /var/log/messages

[Bjoern A. Zeeb]

On Tue, 22 Oct 2002, Bongani wrote:

Hi,

> Hi Alan
>
> I have sent this patch to Gerd and I did not get any reply from him, so...
> The bttv drivers are/were filling up my /var/log/messages file with the
> following output

I had sent a quite similar patch to Gerd and the v4l list (where I am
not subscribed) on Oct 6th. The only thing I got was the "maintainer
action required" reply from the list bot. As the archive is for
subsribers only I cannot say if it ever reached the list.

Alan please include this patch in -ac2.


To Suse-folks: what happend to gerd ? I had seen lots of questions
	regarding v4l2 on this list but no answers.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
56 69 73 69 74				http://www.zabbadoz.net/

Re: [Patch] 2.5.44 Stop bttv_driver.c from flooding /var/log/messages

[Gerd Knorr]

> To Suse-folks: what happend to gerd ? I had seen lots of questions
> 	regarding v4l2 on this list but no answers.

I read lkml very briefly.  Better use the video4linux list, that highly
increases the chance I see it.

  Gerd

PS: I have bttv updates in the queue anyway (also available from
    http://bytesex.org/patches/2.5/).  There are v4l2 patches too.

-- 
You can't please everybody.  And usually if you _try_ to please
everybody, the end result is one big mess.
				-- Linus Torvalds, 2002-04-20