All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Steven Dake <sdake@mvista.com>
Cc: linux-kernel@vger.kernel.org, alan@lxorquk.ukuu.org.uk
Subject: Re: [PATCH] Advanced TCA SCSI/FC disk hotswap driver for kernel 2.5.44
Date: Wed, 23 Oct 2002 17:27:46 -0700	[thread overview]
Message-ID: <20021024002745.GI17413@kroah.com> (raw)
In-Reply-To: <3DB7304A.3030903@mvista.com>

On Wed, Oct 23, 2002 at 04:27:06PM -0700, Steven Dake wrote:
> +static ssize_t scsi_hotswap_insert_by_scsi_id_write_file (struct file 
> *file,
> +    const char *buf, size_t count, loff_t *ppos)
> +{
> +    int host, channel, lun, id;
> +    char parameters[1024];

Ouch, don't put 1k on the stack, dynamically allocate it please.

thanks,

greg k-h

  parent reply	other threads:[~2002-10-24  0:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-23 23:27 [PATCH] Advanced TCA SCSI/FC disk hotswap driver for kernel 2.5.44 Steven Dake
2002-10-24  0:18 ` Greg KH
2002-10-24  0:26   ` Steven Dake
2002-10-24  0:30     ` Greg KH
2002-10-24 16:51     ` Patrick Mochel
2002-10-24  0:27 ` Greg KH [this message]
2002-10-24  0:42 ` Christoph Hellwig
2002-10-24 20:04   ` Steven Dake
     [not found] ` <20021024042838.GA30891@codepoet.org>
2002-10-24 18:12   ` Steven Dake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021024002745.GI17413@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorquk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sdake@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.