Re: [PATCH] Advanced TCA SCSI/FC disk hotswap driver for kernel 2.5.44

[Steven Dake <sdake@mvista.com>]

Greg,


Greg KH wrote:

>On Wed, Oct 23, 2002 at 04:27:06PM -0700, Steven Dake wrote:
>  
>
>>Changes from kernel 2.4.19 to 2.5.44 release:
>>    
>>
>
>First off, your patch is line wrapped, please fix your email client.
>
>Also, please read Documentation/CodingStyle and use tabs.  Unless this
>is a side effect of your email client munging the patch.
>  
>
Thanks yes, it is definately this brain dead mozilla mailer.  I did use 
tabs of course.

>  
>
>>* ioctls deleted and replaced by ramfs scsi_hotswap_fs (suggested by
>>Greg KH)
>>    
>>
>
>Any reason you can't use driverfs for the 2.5 code?
>
>  
>
I'm not sure how driverfs would be used by this particular patch.  Could 
you be more specific in stating how this could be used?

>  
>
>>+/*
>>+ * Core file read/write operations interfaces
>>+ */
>>+static char scsi_hotswap_insert_by_scsi_id_usage[] = {
>>+    "Usage: echo \"[host] [channel] [lun] [id]\" > insert_by_scsi_id\n"
>>+};
>>    
>>
>
>I really like this, a user friendly kernel interface :)
>  
>
Think this looks good for inclusion in 2.5.45?

Thanks
-steve

>thanks,
>
>greg k-h
>
>
>
>  
>