From: Christoph Hellwig <hch@infradead.org>
To: Douglas Gilbert <dougg@torque.net>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] merge sd.h into sd.c and some cleanup
Date: Sun, 27 Oct 2002 14:51:42 +0000 [thread overview]
Message-ID: <20021027145142.A20218@infradead.org> (raw)
In-Reply-To: <3DBBCC5B.50708@torque.net>; from dougg@torque.net on Sun, Oct 27, 2002 at 10:22:03PM +1100
On Sun, Oct 27, 2002 at 10:22:03PM +1100, Douglas Gilbert wrote:
> The patch looks good. However ....
> The header file "sd.h" is included in quite a few lower level
> drivers in lk 2.5.44 (at least 55) and perhaps in a couple of
> other subsystems. The reason it is included is for the
> "biosparam" call in the API of lower level drivers. Whether
> it is still used or useful, I'm not sure. [It does seem
> quite unreasonable that lower level drivers need to include
> an upper level header.]
I've changed the biosparm API in the scsi BK tree, against which this
patch is (see http://linux-scsi.bkbits.net)
> You can drop my credit line (shown above) from sd.c . Perhaps
> James could make a "credits" file for everyone who has helped
> in the 2.5 scsi rework.
I think it's fine to keep it - I just had to shorten it to fit into
a ANSI terminal :)
prev parent reply other threads:[~2002-10-27 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-26 1:18 [PATCH] merge sd.h into sd.c and some cleanup Christoph Hellwig
2002-10-27 11:22 ` Douglas Gilbert
2002-10-27 14:25 ` James Bottomley
2002-10-27 14:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021027145142.A20218@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.