From: Douglas Gilbert <dougg@torque.net>
To: Christoph Hellwig <hch@lst.de>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] merge sd.h into sd.c and some cleanup
Date: Sun, 27 Oct 2002 22:22:03 +1100 [thread overview]
Message-ID: <3DBBCC5B.50708@torque.net> (raw)
In-Reply-To: 20021026031850.A5491@lst.de
Christoph Hellwig wrote:
> Now that only sd.c includes sd.h it can be safely merged into it.
> Also get rid of typedef abuse in sd.c
>
>
> --- 1.76/drivers/scsi/sd.c Thu Oct 24 21:27:14 2002
> +++ edited/drivers/scsi/sd.c Sat Oct 26 01:20:04 2002
> @@ -18,7 +17,7 @@
> * - Alex Davis <letmein@erols.com> Fix problem where partition info
> * not being read in sd_open. Fix problem where removable media
> * could be ejected after sd_open.
> - * - Douglas Gilbert <dgilbert@interlog.com> cleanup for lk 2.5 series
> + * - Douglas Gilbert <dgilbert@interlog.com> cleanup for lk 2.5.x
> *
<snip>
Christoph,
The patch looks good. However ....
The header file "sd.h" is included in quite a few lower level
drivers in lk 2.5.44 (at least 55) and perhaps in a couple of
other subsystems. The reason it is included is for the
"biosparam" call in the API of lower level drivers. Whether
it is still used or useful, I'm not sure. [It does seem
quite unreasonable that lower level drivers need to include
an upper level header.]
You can drop my credit line (shown above) from sd.c . Perhaps
James could make a "credits" file for everyone who has helped
in the 2.5 scsi rework.
Doug Gilbert
next prev parent reply other threads:[~2002-10-27 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-26 1:18 [PATCH] merge sd.h into sd.c and some cleanup Christoph Hellwig
2002-10-27 11:22 ` Douglas Gilbert [this message]
2002-10-27 14:25 ` James Bottomley
2002-10-27 14:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DBBCC5B.50708@torque.net \
--to=dougg@torque.net \
--cc=James.Bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.