All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: axboe@suse.de
Cc: badari@us.ibm.com, James.Bottomley@steeleye.com,
	pbadari@us.ibm.com, akpm@digeo.com, linux-scsi@vger.kernel.org,
	Martin.Bligh@us.ibm.com, dledford@redhat.com
Subject: Re: possible use-after-free in 2.5.44 scsi changes
Date: Wed, 30 Oct 2002 12:35:19 -0800 (PST)	[thread overview]
Message-ID: <20021030.123519.25407274.davem@redhat.com> (raw)
In-Reply-To: <20021030181627.GV3416@suse.de>

   From: Jens Axboe <axboe@suse.de>
   Date: Wed, 30 Oct 2002 19:16:27 +0100

   On Wed, Oct 30 2002, Badari Pulavarty wrote:
   > What does BIOVEC_VIRT_MERGEABLE() supposed to do ? I am guessing
   > it is supposed to restrict IO crossing 4GB boundary. Is it correct ?
   
   It's only for platforms with iommu that can do funky remapping tricks
   for pages ending on certain boundaries. I'm sure davem or anton can tell
   you more about this for sparc64 or ppc64. For x86, it will always be
   true. Hmm, looking at it, I can't convince myself that it is right.
   Davem, could you please check up on this? I'll be back later tonight to
   review it as well. Things are not consistent, I agree on that.

This whole report sounds like ppc64 is setting BIO_VMERGE_BOUNDARY
incorrectly.

If the IOMMU code on ppc64 is not going to merge physical scatterlist
segments which begin/end on a page boundry into a single DMA addr/len
pair, then this port should not be setting BIO_VMERGE_BOUNDARY
non-zero.

Else, if ppc64's IOMMU code will merge such pages, BIO_VMERGE_BOUNDARY
must be defined to the page size used by the IOMMU.

I notice now that the BIO_VMERGE_BOUNDARY define is "#if 0" protected
on ppc64.  It absolutely must be in sync with how the IOMMU code on
the platform behaves.  So some ppc64 expert needs to comment :)

  parent reply	other threads:[~2002-10-30 20:35 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-25  1:39 possible use-after-free in 2.5.44 scsi changes Andrew Morton
2002-10-25  4:06 ` Doug Ledford
2002-10-25  4:40   ` Andrew Morton
2002-10-25 14:21     ` James Bottomley
2002-10-25  4:07 ` Patrick Mansfield
2002-10-25 14:16 ` James Bottomley
2002-10-25 18:34   ` James Bottomley
2002-10-25 18:49     ` Mike Anderson
2002-10-25 19:08     ` Patrick Mansfield
2002-10-25 19:41       ` Mike Anderson
2002-10-25 19:47         ` Jens Axboe
2002-10-25 22:14           ` James Bottomley
2002-10-25 22:18             ` Andrew Morton
2002-10-25 22:23     ` Badari Pulavarty
2002-10-26  0:13       ` James Bottomley
2002-10-26  0:18         ` Mike Anderson
2002-10-26  9:29         ` Jens Axboe
2002-10-27  0:50           ` James Bottomley
2002-10-27 21:20             ` Jens Axboe
2002-10-27 21:37               ` James Bottomley
2002-10-27 21:54                 ` Jens Axboe
2002-10-30 17:39                   ` Badari Pulavarty
2002-10-30 18:16                     ` Jens Axboe
2002-10-30 19:31                       ` Badari Pulavarty
2002-10-30 21:36                         ` merlin hughes
2002-10-30 22:19                           ` Badari Pulavarty
2002-10-31  2:17                             ` merlin
2002-10-31 13:18                               ` Jens Axboe
2002-10-31 14:41                                 ` merlin
2002-10-31 14:46                                   ` Jens Axboe
2002-10-31 15:04                             ` Jens Axboe
2002-10-31 15:12                               ` Jens Axboe
2002-10-31 17:41                                 ` merlin
2002-10-30 20:35                       ` David S. Miller [this message]
2002-10-30 22:03                         ` Badari Pulavarty
  -- strict thread matches above, loose matches on Subject: below --
2002-10-31 17:57 Badari Pulavarty
2002-10-31 18:46 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021030.123519.25407274.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=Martin.Bligh@us.ibm.com \
    --cc=akpm@digeo.com \
    --cc=axboe@suse.de \
    --cc=badari@us.ibm.com \
    --cc=dledford@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.