From: Christoph Hellwig <hch@infradead.org>
To: Matthias Urlichs <smurf@noris.de>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: PATCH 2.4: scsi and BLK_STATS
Date: Wed, 13 Nov 2002 01:37:17 +0000 [thread overview]
Message-ID: <20021113013717.A3008@infradead.org> (raw)
In-Reply-To: <20021113023059.K18881@noris.de>; from smurf@noris.de on Wed, Nov 13, 2002 at 02:30:59AM +0100
On Wed, Nov 13, 2002 at 02:30:59AM +0100, Matthias Urlichs wrote:
> That may be a matter of style, but I would strongly prefer these to be
>
> #define req_new_io(_a,_b,_c) do {} while(0)
> #define req_merge_io(_a) do {} while(0)
> #define req_finished_io(_a) do {} while(0)
>
> instead ...
In kernelspace inlines are usually preferred over macros, that's why
I wrote it that way. I must adimt that I don't really care a lot
personally..
> anyway, please disregard my patch and add
>
> #include <linux/genhd.h>
>
> in scsi/scsi_lib.c. :-/
It already gets genhd.h through blk.h -> blkdev.h.. :)
next prev parent reply other threads:[~2002-11-13 1:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-12 17:28 PATCH 2.4: scsi and BLK_STATS Matthias Urlichs
2002-11-13 0:15 ` Christoph Hellwig
2002-11-13 1:30 ` Matthias Urlichs
2002-11-13 1:37 ` Christoph Hellwig [this message]
2002-11-13 1:41 ` Matthias Urlichs
2002-11-13 2:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021113013717.A3008@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smurf@noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.