From: "Matthias Urlichs" <smurf@noris.de>
To: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: PATCH 2.4: scsi and BLK_STATS
Date: Wed, 13 Nov 2002 02:30:59 +0100 [thread overview]
Message-ID: <20021113023059.K18881@noris.de> (raw)
In-Reply-To: <20021113001530.A323@infradead.org>; from hch@infradead.org on Wed, Nov 13, 2002 at 12:15:30AM +0000
Hi,
Christoph Hellwig:
> On Tue, Nov 12, 2002 at 06:28:21PM +0100, Matthias Urlichs wrote:
> > Some people might want SCSI without block statistics...
>
> Probably. But your patch doesn;t gain them anything but a useless
> ifdef.. Look at include/linux/genhd.h:
>
*Sigh*
Note that scsi_lib.c does not include linux/genhd.h, thus I missed
that. :-/
> static inline void req_new_io(struct request *req, int merge, int sectors) { }
> static inline void req_merged_io(struct request *req) { }
> static inline void req_finished_io(struct request *req) { }
That may be a matter of style, but I would strongly prefer these to be
#define req_new_io(_a,_b,_c) do {} while(0)
#define req_merge_io(_a) do {} while(0)
#define req_finished_io(_a) do {} while(0)
instead ... anyway, please disregard my patch and add
#include <linux/genhd.h>
in scsi/scsi_lib.c. :-/
--
Matthias Urlichs | noris network AG | http://smurf.noris.de/
next prev parent reply other threads:[~2002-11-13 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-12 17:28 PATCH 2.4: scsi and BLK_STATS Matthias Urlichs
2002-11-13 0:15 ` Christoph Hellwig
2002-11-13 1:30 ` Matthias Urlichs [this message]
2002-11-13 1:37 ` Christoph Hellwig
2002-11-13 1:41 ` Matthias Urlichs
2002-11-13 2:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021113023059.K18881@noris.de \
--to=smurf@noris.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.