* [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c
@ 2002-12-11 22:28 Bob Miller
2002-12-12 1:29 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Bob Miller @ 2002-12-11 22:28 UTC (permalink / raw)
To: trivial; +Cc: linux-kernel
The function, cs5520_tune_chipset() is declared to return an int.
Added a return statement instead of just falling of off the bottom.
diff -Nru a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c
--- a/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
+++ b/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
@@ -166,6 +166,8 @@
/* ATAPI is harder so leave it for now */
if(!error && drive->media == ide_disk)
error = hwif->ide_dma_on(drive);
+
+ return error;
}
static void cs5520_tune_drive(ide_drive_t *drive, u8 pio)
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c
2002-12-11 22:28 [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c Bob Miller
@ 2002-12-12 1:29 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2002-12-12 1:29 UTC (permalink / raw)
To: Bob Miller; +Cc: trivial, Linux Kernel Mailing List
On Wed, 2002-12-11 at 22:28, Bob Miller wrote:
> The function, cs5520_tune_chipset() is declared to return an int.
> Added a return statement instead of just falling of off the bottom.
>
> diff -Nru a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c
> --- a/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
> +++ b/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
> @@ -166,6 +166,8 @@
> /* ATAPI is harder so leave it for now */
> if(!error && drive->media == ide_disk)
> error = hwif->ide_dma_on(drive);
> +
> + return error;
Eep thats a nasty little bug, lucky my compiler left the error value in
%eax anyway good spotting
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-12-12 0:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-11 22:28 [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c Bob Miller
2002-12-12 1:29 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.