[PATCH]: c-r4k.c, new gcc's don't like empty labels

[PATCH]: c-r4k.c, new gcc's don't like empty labels

[Juan Quintela]

Hi
        patch is trivial to eliminate warnings from the compiler

Later, Juan.

Index: arch/mips/mm/c-r4k.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/mm/c-r4k.c,v
retrieving revision 1.3.2.13
diff -u -r1.3.2.13 c-r4k.c
--- arch/mips/mm/c-r4k.c	11 Dec 2002 14:23:12 -0000	1.3.2.13
+++ arch/mips/mm/c-r4k.c	18 Dec 2002 00:49:18 -0000
@@ -465,7 +465,7 @@
 		blast_scache16_page_indexed(page);
 	} else
 		blast_scache16_page(page);
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_s32d16i16(struct vm_area_struct *vma,
@@ -511,7 +511,7 @@
 		blast_scache32_page_indexed(page);
 	} else
 		blast_scache32_page(page);
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_s64d16i16(struct vm_area_struct *vma,
@@ -557,7 +557,7 @@
 		blast_scache64_page_indexed(page);
 	} else
 		blast_scache64_page(page);
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_s128d16i16(struct vm_area_struct *vma,
@@ -604,7 +604,7 @@
 		blast_scache128_page_indexed(page);
 	} else
 		blast_scache128_page(page);
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_s32d32i32(struct vm_area_struct *vma,
@@ -651,7 +651,7 @@
 		blast_scache32_page_indexed(page);
 	} else
 		blast_scache32_page(page);
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_s64d32i32(struct vm_area_struct *vma,
@@ -698,7 +698,7 @@
 		blast_scache64_page_indexed(page);
 	} else
 		blast_scache64_page(page);
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_s128d32i32(struct vm_area_struct *vma,
@@ -744,7 +744,7 @@
 		blast_scache128_page_indexed(page);
 	} else
 		blast_scache128_page(page);
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_d16i16(struct vm_area_struct *vma,
@@ -789,7 +789,7 @@
 		page = (KSEG0 + (page & (dcache_size - 1)));
 		blast_dcache16_page_indexed(page);
 	}
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_d32i32(struct vm_area_struct *vma,
@@ -835,7 +835,7 @@
 		page = (KSEG0 + (page & (dcache_size - 1)));
 		blast_dcache32_page_indexed(page);
 	}
-out:
+out:;
 }
 
 static void r4k_flush_cache_page_d32i32_r4600(struct vm_area_struct *vma,
@@ -881,7 +881,7 @@
 		blast_dcache32_page_indexed(page);
 		blast_dcache32_page_indexed(page ^ dcache_waybit);
 	}
-out:
+out:;
 }
 
 static void r4k_flush_page_to_ram_s16(struct page *page)


-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

Re: [PATCH]: c-r4k.c, new gcc's don't like empty labels

[Ralf Baechle]

On Wed, Dec 18, 2002 at 02:43:07AM +0100, Juan Quintela wrote:

>         patch is trivial to eliminate warnings from the compiler

And yet I didn't like it.  The new syntax requirement isn't only ugly code,
it's harder to read than a replacing the gotos with a simple return ...

  Ralf

Re: [PATCH]: c-r4k.c, new gcc's don't like empty labels

[Juan Quintela]

>>>>> "ralf" == Ralf Baechle <ralf@linux-mips.org> writes:

ralf> On Wed, Dec 18, 2002 at 02:43:07AM +0100, Juan Quintela wrote:
>> patch is trivial to eliminate warnings from the compiler

ralf> And yet I didn't like it.  The new syntax requirement isn't only ugly code,
ralf> it's harder to read than a replacing the gotos with a simple return ...

I thought that the gotos to end was there for generation of code
reasons.

It is not good in the first place to have labels called out :(

Later, Juan.


-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

Re: [PATCH]: c-r4k.c, new gcc's don't like empty labels

[Ralf Baechle]

On Wed, Dec 18, 2002 at 11:19:24PM +0100, Juan Quintela wrote:

> ralf> On Wed, Dec 18, 2002 at 02:43:07AM +0100, Juan Quintela wrote:
> >> patch is trivial to eliminate warnings from the compiler
> 
> ralf> And yet I didn't like it.  The new syntax requirement isn't only ugly code,
> ralf> it's harder to read than a replacing the gotos with a simple return ...
> 
> I thought that the gotos to end was there for generation of code
> reasons.

Doesn't make a code difference in this case for MIPS.

  Ralf