* [PATCH]: correct format string in dump_tlb
@ 2002-12-18 1:43 Juan Quintela
2002-12-18 22:59 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Juan Quintela @ 2002-12-18 1:43 UTC (permalink / raw)
To: linux mips mailing list, Ralf Baechle
Hi
if we cast to unsigned it, print it as a long is a no-no :(
Later, Juan.
Index: arch/mips/lib/dump_tlb.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/lib/dump_tlb.c,v
retrieving revision 1.8.2.5
diff -u -r1.8.2.5 dump_tlb.c
--- arch/mips/lib/dump_tlb.c 2 Dec 2002 00:24:48 -0000 1.8.2.5
+++ arch/mips/lib/dump_tlb.c 18 Dec 2002 00:49:18 -0000
@@ -179,7 +180,7 @@
#ifdef CONFIG_64BIT_PHYS_ADDR
printk("page == %08Lx\n", (unsigned long long) pte_val(page));
#else
- printk("page == %08lx\n", (unsigned int) pte_val(page));
+ printk("page == %08x\n", (unsigned int) pte_val(page));
#endif
val = pte_val(page);
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]: correct format string in dump_tlb
2002-12-18 1:43 [PATCH]: correct format string in dump_tlb Juan Quintela
@ 2002-12-18 22:59 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2002-12-18 22:59 UTC (permalink / raw)
To: Juan Quintela; +Cc: linux mips mailing list
On Wed, Dec 18, 2002 at 02:43:37AM +0100, Juan Quintela wrote:
> if we cast to unsigned it, print it as a long is a no-no :(
Correct but I didn't like your patch ...
> - printk("page == %08lx\n", (unsigned int) pte_val(page));
> + printk("page == %08x\n", (unsigned int) pte_val(page));
pte_val() returns unsigned long. So I applied a different fix.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-12-18 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-18 1:43 [PATCH]: correct format string in dump_tlb Juan Quintela
2002-12-18 22:59 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.