[PATCH]: make prototype of printk available

[PATCH]: make prototype of printk available

[Juan Quintela]

Hi
        this complained about printk being undefined.
        Once there, put a tag to the printk.

Later, Juan.

Index: arch/mips/math-emu/ieee754xcpt.c
===================================================================
RCS file: /home/cvs/linux/arch/mips/math-emu/ieee754xcpt.c,v
retrieving revision 1.3.2.1
diff -u -r1.3.2.1 ieee754xcpt.c
--- arch/mips/math-emu/ieee754xcpt.c	5 Aug 2002 23:53:34 -0000	1.3.2.1
+++ arch/mips/math-emu/ieee754xcpt.c	18 Dec 2002 00:49:18 -0000
@@ -29,6 +29,7 @@
  *  Copyright (C) 2000 MIPS Technologies, Inc.  All rights reserved.
  *************************************************************************/
 
+#include <linux/kernel.h>
 #include "ieee754.h"
 
 /*
@@ -42,7 +43,7 @@
 
 void ieee754_xcpt(struct ieee754xctx *xcp)
 {
-	printk("floating point exception in \"%s\", type=%s\n",
+	printk(KERN_INFO "floating point exception in \"%s\", type=%s\n",
 		xcp->op, rtnames[xcp->rt]);
 }
 


-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

Re: [PATCH]: make prototype of printk available

[Maciej W. Rozycki]

On 18 Dec 2002, Juan Quintela wrote:

>         Once there, put a tag to the printk.

 Why is the default log level incorrect here?

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

Re: [PATCH]: make prototype of printk available

[Ralf Baechle]

On Wed, Dec 18, 2002 at 05:37:49PM +0100, Maciej W. Rozycki wrote:

> >         Once there, put a tag to the printk.
> 
>  Why is the default log level incorrect here?

This is a printk that's executed if a user program is just trying to
execute the right code, so a user could flood syslog that way.  Imho the
printk call should go away?

  Ralf

Re: [PATCH]: make prototype of printk available

[Maciej W. Rozycki]

On Thu, 19 Dec 2002, Ralf Baechle wrote:

> This is a printk that's executed if a user program is just trying to
> execute the right code, so a user could flood syslog that way.  Imho the
> printk call should go away?

 Indeed -- that's a report of a non-fatal exception.  If unhandled, user
will get output from the default signal handler.  And if diagnostics is
needed in the emulator, Dprintk or a similar solution may be used. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

Re: [PATCH]: make prototype of printk available

[Juan Quintela]

>>>>> "maciej" == Maciej W Rozycki <macro@ds2.pg.gda.pl> writes:

maciej> On 18 Dec 2002, Juan Quintela wrote:
>> Once there, put a tag to the printk.

maciej> Why is the default log level incorrect here?

The problem (not here in general), is that if printk's use the default
log level, then you as a user has no way to raise/lower the default
log level (i.e. the messages that you want to printk or not).

Later, Juan.

-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

Re: [PATCH]: make prototype of printk available

[Maciej W. Rozycki]

On 19 Dec 2002, Juan Quintela wrote:

> maciej> Why is the default log level incorrect here?
> 
> The problem (not here in general), is that if printk's use the default
> log level, then you as a user has no way to raise/lower the default
> log level (i.e. the messages that you want to printk or not).

 Well, the default level is KERN_WARNING and can be changed using sysctl. 
Otherwise it's handled identically to explicitly tagged messages -- you
may control direct console output with the same sysctl. 

 Obviously there are printks that beg for an explicit tag.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +