From: "Andrey Panin" <pazke@orbita1.ru>
To: Miles Bader <miles@gnu.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] irq handling code consolidation, second try (v850 part)
Date: Sat, 4 Jan 2003 16:03:52 +0300 [thread overview]
Message-ID: <20030104130352.GK10477@pazke> (raw)
In-Reply-To: <87hecp83yq.fsf@tc-1-100.kawasaki.gol.ne.jp>
On Sat, Jan 04, 2003 at 10:00:29PM +0900, Miles Bader wrote:
> Can't test it, but the v850 part looks great, ah, it's lovely to see all
> that code being deleted...
>
> One comment: `arch_check_irq' is a bad name, it doesn't make it at all
> clear what it does.
>
> I might suggest inverting the sense, and using `irq_valid' -- the `arch_'
> prefix seems unnecessary (as with `irq_desc') since it's not a
> arch-specific version of a more general wrapper.
I used arch_ prefix to clearly mark arch specifig things, but
irq_valid() is probably a better name. Comments ?
--
Andrey Panin | Embedded systems software developer
pazke@orbita1.ru | PGP key: wwwkeys.pgp.net
next prev parent reply other threads:[~2003-01-04 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-04 13:00 [RFC] irq handling code consolidation, second try (v850 part) Miles Bader
2003-01-04 13:03 ` Andrey Panin [this message]
2003-01-04 13:57 ` Miles Bader
-- strict thread matches above, loose matches on Subject: below --
2003-01-04 12:00 Andrey Panin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030104130352.GK10477@pazke \
--to=pazke@orbita1.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.