From: Miles Bader <miles@gnu.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [RFC] irq handling code consolidation, second try (v850 part)
Date: Sat, 4 Jan 2003 08:57:06 -0500 [thread overview]
Message-ID: <20030104135706.GA12349@gnu.org> (raw)
In-Reply-To: <20030104130352.GK10477@pazke>
On Sat, Jan 04, 2003 at 04:03:52PM +0300, Andrey Panin wrote:
> I used arch_ prefix to clearly mark arch specifig things, but
> irq_valid() is probably a better name. Comments ?
You should only `mark arch specific things' when there's a reason --
after all, there are _lots_ of arch-specific definitions in linux, but very
rarely is it important to note that fact; the caller usually doesn't care.
[consider that it might be desirable at some point in the future to have a
arch-independent version of `irq_valid'; the callers shouldn't have to be
changed to accomodate such a change]
In the case of something like `arch_setup_irq', there _is_ a reason: it's a
small arch-specific `core' for the real generic setup_irq (and one which will
probably be used _only_ by setup_irq).
-Miles
--
Ich bin ein Virus. Mach' mit und kopiere mich in Deine .signature.
next prev parent reply other threads:[~2003-01-04 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-04 13:00 [RFC] irq handling code consolidation, second try (v850 part) Miles Bader
2003-01-04 13:03 ` Andrey Panin
2003-01-04 13:57 ` Miles Bader [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-01-04 12:00 Andrey Panin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030104135706.GA12349@gnu.org \
--to=miles@gnu.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.