From: Adrian Bunk <bunk@fs.tum.de>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [2.5 patch] go to drivers/ide/pci/ even for !CONFIG_BLK_DEV_IDEPCI
Date: Sat, 11 Jan 2003 14:11:00 +0100 [thread overview]
Message-ID: <20030111131059.GK10486@fs.tum.de> (raw)
Hi Alan,
I observed the following problem with the cmd640 driver in 2.5.56:
- cmd640.c is in the drivers/ide/pci/ subdirectory.
- BLK_DEV_CMD640 does not depend on BLK_DEV_IDEPCI
- drivers/ide/Makefile only goes to pci/ if BLK_DEV_IDEPCI is selected
If the .config contains the following legal configuration:
<-- snip -->
...
CONFIG_BLK_DEV_CMD640=y
...
# CONFIG_BLK_DEV_IDEPCI is not set
...
<-- snip -->
the cmd640 driver isn't built.
The following patch fixes this (similar to 2.4 where pci/ is already
visited for !CONFIG_BLK_DEV_IDEPCI):
--- linux-2.5.56/drivers/ide/Makefile.old 2003-01-11 13:52:30.000000000 +0100
+++ linux-2.5.56/drivers/ide/Makefile 2003-01-11 13:52:51.000000000 +0100
@@ -10,7 +10,7 @@
export-objs := ide-iops.o ide-taskfile.o ide-proc.o ide.o ide-probe.o ide-dma.o ide-lib.o setup-pci.o ide-io.o
# First come modules that register themselves with the core
-obj-$(CONFIG_BLK_DEV_IDEPCI) += pci/
+obj-$(CONFIG_BLK_DEV_IDE) += pci/
# Core IDE code - must come before legacy
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2003-01-11 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 13:11 Adrian Bunk [this message]
2003-01-11 13:25 ` [2.5 patch] go to drivers/ide/pci/ even for !CONFIG_BLK_DEV_IDEPCI Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030111131059.GK10486@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.