From: Alan Cox <alan@redhat.com>
To: bunk@fs.tum.de (Adrian Bunk)
Cc: alan@redhat.com (Alan Cox), linux-kernel@vger.kernel.org
Subject: Re: [2.5 patch] go to drivers/ide/pci/ even for !CONFIG_BLK_DEV_IDEPCI
Date: Sat, 11 Jan 2003 08:25:22 -0500 (EST) [thread overview]
Message-ID: <200301111325.h0BDPMr00756@devserv.devel.redhat.com> (raw)
In-Reply-To: <20030111131059.GK10486@fs.tum.de> from "Adrian Bunk" at Jan 11, 2003 02:11:00 PM
> I observed the following problem with the cmd640 driver in 2.5.56:
I know
> - cmd640.c is in the drivers/ide/pci/ subdirectory.
> - BLK_DEV_CMD640 does not depend on BLK_DEV_IDEPCI
This is correct
> - drivers/ide/Makefile only goes to pci/ if BLK_DEV_IDEPCI is selected
> If the .config contains the following legal configuration:
There are a lot of configurations with this property.
> The following patch fixes this (similar to 2.4 where pci/ is already
> visited for !CONFIG_BLK_DEV_IDEPCI):
>
> --- linux-2.5.56/drivers/ide/Makefile.old 2003-01-11 13:52:30.000000000 +0100
> +++ linux-2.5.56/drivers/ide/Makefile 2003-01-11 13:52:51.000000000 +0100
> @@ -10,7 +10,7 @@
> export-objs := ide-iops.o ide-taskfile.o ide-proc.o ide.o ide-probe.o ide-dma.o ide-lib.o setup-pci.o ide-io.o
>
> # First come modules that register themselves with the core
> -obj-$(CONFIG_BLK_DEV_IDEPCI) += pci/
> +obj-$(CONFIG_BLK_DEV_IDE) += pci/
I think thats the best approach.
prev parent reply other threads:[~2003-01-11 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 13:11 [2.5 patch] go to drivers/ide/pci/ even for !CONFIG_BLK_DEV_IDEPCI Adrian Bunk
2003-01-11 13:25 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200301111325.h0BDPMr00756@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.