From: Dominik Brodowski <linux@brodo.de>
To: Dave Jones <davej@codemonkey.org.uk>,
torvalds@transmeta.com, davej@suse.de,
linux-kernel@vger.kernel.org, cpufreq@www.linux.org.uk
Subject: Re: [PATCH] cpufreq: move frequency table helpers to extra module
Date: Thu, 13 Feb 2003 11:00:29 +0100 [thread overview]
Message-ID: <20030213100029.GA14301@brodo.de> (raw)
In-Reply-To: <20030213093951.GA22151@codemonkey.org.uk>
On Thu, Feb 13, 2003 at 09:39:51AM +0000, Dave Jones wrote:
> On Thu, Feb 13, 2003 at 10:11:31AM +0100, Dominik Brodowski wrote:
> > The CPU frequency table helpers can easily be modularized --
> > especially as they are not needed on all architectures, or for
> > all drivers.
>
> As most of the x86 drivers have been converted now, it looks like
> it'd make more sense to conditionalise this on architecture, and
> move the remaining x86 drivers over to the helpers (longrun/longhaul).
Longhaul yes, Longrun no. On longrun you can't set the speed to a specific
frequency[*], only to a _frequency range_. So the frequency table helpers
aren't needed there. Also, for gx-suspmod, which allows really fine-grained
setting of frequencies, the frequency table helpers don't make sense.
> It just strikes me as silly that we have a config option that when
> disabled could end up showing no chip drivers when the conversion
> is complete.
So, even when the conversion is complete, there are two drivers which can be
compiled. Additionally, some users (or distros!) might prefer modularizing
this.
Dominik
[*] you can set policy->max = policy->min, but that really doesn't make
sense on longrun.
next prev parent reply other threads:[~2003-02-13 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-13 9:11 [PATCH] cpufreq: move frequency table helpers to extra module Dominik Brodowski
2003-02-13 9:39 ` Dave Jones
2003-02-13 10:00 ` Dominik Brodowski [this message]
2003-02-13 10:17 ` Roman Zippel
2003-02-13 11:14 ` [PATCH UPDATED] " Dominik Brodowski
2003-02-15 20:53 ` Linus Torvalds
2003-02-15 22:57 ` [PATCH] cpufreq: fix compilation of ACPI if !CPU_FREQ [Was: Re: [PATCH UPDATED] cpufreq: move frequency table helpers to extra module] Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030213100029.GA14301@brodo.de \
--to=linux@brodo.de \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.