All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@brodo.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: davej@suse.de, linux-kernel@vger.kernel.org, cpufreq@www.linux.org.uk
Subject: [PATCH] cpufreq: fix compilation of ACPI if !CPU_FREQ [Was: Re: [PATCH UPDATED] cpufreq: move frequency table helpers to extra module]
Date: Sat, 15 Feb 2003 23:57:38 +0100	[thread overview]
Message-ID: <20030215225738.GA1363@brodo.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0302151252110.21697-100000@home.transmeta.com>

On Sat, Feb 15, 2003 at 12:53:56PM -0800, Linus Torvalds wrote:
> 
> Dominic,
>  this broke ACPI. 
> 
> 	In file included from drivers/acpi/processor.c:49:
> 	include/acpi/processor.h:78: field `freq_table' has incomplete type
> 
> AGAIN.
> 
> For about the 15th time. 
> 
> You guys need to talk more. A LOT more. Or y ou need to start checking who 
> is actually _using_ the frequency code, and when you make changes to the 
> interfaces you need to _update_ the users, instead of just causing kernel 
> compiles to fail every frigging time you make a change.
> 
> 		Linus

Linus,

here's the compile fix for this breakage which only appears if
CONFIG_ACPI && !(CONFIG_CPU_FREQ_TABLE || CONFIG_CPU_FREQ_TABLE_MODULE)
Unfortunately, I forgot to test-compile this combination. Sorry about
that.

	Dominik

diff -u linux-original/include/linux/cpufreq.h linux/include/linux/cpufreq.h
--- linux-original/include/linux/cpufreq.h	2003-02-15 23:35:14.000000000 +0100
+++ linux/include/linux/cpufreq.h	2003-02-15 23:28:32.000000000 +0100
@@ -299,7 +299,7 @@
 
 #endif /* CONFIG_CPU_FREQ_24_API */
 
-#if defined(CONFIG_CPU_FREQ_TABLE) || defined(CONFIG_CPU_FREQ_TABLE_MODULE)
+
 /*********************************************************************
  *                     FREQUENCY TABLE HELPERS                       *
  *********************************************************************/
@@ -313,6 +313,7 @@
 				    * order */
 };
 
+#if defined(CONFIG_CPU_FREQ_TABLE) || defined(CONFIG_CPU_FREQ_TABLE_MODULE)
 int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy,
 				    struct cpufreq_frequency_table *table);
 

      reply	other threads:[~2003-02-15 22:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-13  9:11 [PATCH] cpufreq: move frequency table helpers to extra module Dominik Brodowski
2003-02-13  9:39 ` Dave Jones
2003-02-13 10:00   ` Dominik Brodowski
2003-02-13 10:17 ` Roman Zippel
2003-02-13 11:14   ` [PATCH UPDATED] " Dominik Brodowski
2003-02-15 20:53     ` Linus Torvalds
2003-02-15 22:57       ` Dominik Brodowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030215225738.GA1363@brodo.de \
    --to=linux@brodo.de \
    --cc=cpufreq@www.linux.org.uk \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.