From: Russell King <rmk@arm.linux.org.uk>
To: Valdis.Kletnieks@vt.edu
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.60 - drivers/char/esp.c vs include/linux/serialP.h
Date: Fri, 14 Feb 2003 20:54:49 +0000 [thread overview]
Message-ID: <20030214205449.J14659@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200302142039.h1EKdYwZ029474@turing-police.cc.vt.edu>; from Valdis.Kletnieks@vt.edu on Fri, Feb 14, 2003 at 03:39:34PM -0500
On Fri, Feb 14, 2003 at 03:39:34PM -0500, Valdis.Kletnieks@vt.edu wrote:
> compiling drivers/char/esp.c with -Wundef triggers a warning:
>
> In file included from drivers/char/esp.c:51:
> include/linux/serialP.h:27:6: warning: "LINUX_VERSION_CODE" is not defined
>
> The code that trips it up:
>
> #if (LINUX_VERSION_CODE < 0x020300)
> /* Unfortunate, but Linux 2.2 needs async_icount defined here and
> * it got moved in 2.3 */
> #include <linux/serial.h>
> #endif
>
> It's unclear if this should be fixed by adding a #include <linux/version.h>
> to esp.c, or if this code should summarily be lopped out of serialP.h.
My personal feeling woudl be to lop it out, and fix up anywhere
and everywhere which complains appropraitely.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-02-14 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-14 20:39 2.5.60 - drivers/char/esp.c vs include/linux/serialP.h Valdis.Kletnieks
2003-02-14 20:54 ` Russell King [this message]
2003-02-14 21:16 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030214205449.J14659@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.