2.5.60 - drivers/char/esp.c vs include/linux/serialP.h

2.5.60 - drivers/char/esp.c vs include/linux/serialP.h

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

compiling drivers/char/esp.c with -Wundef triggers a warning:

In file included from drivers/char/esp.c:51:
include/linux/serialP.h:27:6: warning: "LINUX_VERSION_CODE" is not defined

The code that trips it up:

#if (LINUX_VERSION_CODE < 0x020300)
/* Unfortunate, but Linux 2.2 needs async_icount defined here and
 * it got moved in 2.3 */
#include <linux/serial.h>
#endif

It's unclear if this should be fixed by adding a #include <linux/version.h>
to esp.c, or if this code should summarily be lopped out of serialP.h.


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.5.60 - drivers/char/esp.c vs include/linux/serialP.h

[Russell King]

On Fri, Feb 14, 2003 at 03:39:34PM -0500, Valdis.Kletnieks@vt.edu wrote:
> compiling drivers/char/esp.c with -Wundef triggers a warning:
> 
> In file included from drivers/char/esp.c:51:
> include/linux/serialP.h:27:6: warning: "LINUX_VERSION_CODE" is not defined
> 
> The code that trips it up:
> 
> #if (LINUX_VERSION_CODE < 0x020300)
> /* Unfortunate, but Linux 2.2 needs async_icount defined here and
>  * it got moved in 2.3 */
> #include <linux/serial.h>
> #endif
> 
> It's unclear if this should be fixed by adding a #include <linux/version.h>
> to esp.c, or if this code should summarily be lopped out of serialP.h.

My personal feeling woudl be to lop it out, and fix up anywhere
and everywhere which complains appropraitely.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: 2.5.60 - drivers/char/esp.c vs include/linux/serialP.h

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Fri, 14 Feb 2003 20:54:49 GMT, Russell King said:
> On Fri, Feb 14, 2003 at 03:39:34PM -0500, Valdis.Kletnieks@vt.edu wrote:
> > compiling drivers/char/esp.c with -Wundef triggers a warning:
> > 
> > In file included from drivers/char/esp.c:51:
> > include/linux/serialP.h:27:6: warning: "LINUX_VERSION_CODE" is not defined

> My personal feeling woudl be to lop it out, and fix up anywhere
> and everywhere which complains appropraitely.

I jumped the gun, actually - the build was still running, and there's at
least 6 other things that trigger the same serialP.h warning - where there's
a #if (VAR < NNNN) check that Does The Wrong Thing because of the default
gcc behavior for undefineds.  Hopefully this one's harmless - but there's
still 608 other warnings to work through.



[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]