Re: MIDI port names

[Pedro Lopez-Cabanillas <plcl@telefonica.net>]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

On Wednesday 19 February 2003 14:51, Takashi Iwai wrote:
> there is the name field for each rawmidi substream, and the sequencer
> looks up this string.
>
> this reminds me the former patch by Clemens, and i've forgotten to
> check this issue until now.  sorry.
>
> i modified the sequencer part (and mpu401_uart) on the cvs so that the
> sequencer retrieves the rawmidi name string if the substream name is
> not defined. 

But Clemens' patch (attached is a slightly modified version) was not for port 
names but for client names, from "External MIDI x" to the more meaningful 
rawmidi name. I think that this is what some people is requesting, and makes 
things easier for large studio setups when some applications, like kaconnect, 
show client names but not port names. Please, apply.

Regards,
Pedro

-- 
ALSA Library Bindings for Pascal
http://alsapas.alturl.com


[-- Attachment #2: seq_midi.c.patch --]
[-- Type: text/x-diff, Size: 554 bytes --]

--- alsa-kernel/core/seq/seq_midi.c.old	Wed Feb 19 23:23:50 2003
+++ alsa-kernel/core/seq/seq_midi.c	Thu Feb 20 00:20:09 2003
@@ -329,7 +329,10 @@
 		memset(&inf,0,sizeof(snd_seq_client_info_t));
 		inf.client = client->seq_client;
 		inf.type = KERNEL_CLIENT;
-		sprintf(inf.name, "External MIDI %i", card->number);
+		if (info.name[0])
+			strncpy(inf.name, info.name, sizeof(inf.name) - 1);
+		else
+			sprintf(inf.name, "External MIDI %i", card->number);
 		snd_seq_kernel_client_ctl(client->seq_client, SNDRV_SEQ_IOCTL_SET_CLIENT_INFO, &inf);
 	}