Re: MIDI port names

[Takashi Iwai <tiwai@suse.de>]

At Thu, 20 Feb 2003 09:55:18 +0100 (CET),
Jaroslav wrote:
> 
> On Thu, 20 Feb 2003, Pedro Lopez-Cabanillas wrote:
> 
> > On Wednesday 19 February 2003 14:51, Takashi Iwai wrote:
> > > there is the name field for each rawmidi substream, and the sequencer
> > > looks up this string.
> > >
> > > this reminds me the former patch by Clemens, and i've forgotten to
> > > check this issue until now.  sorry.
> > >
> > > i modified the sequencer part (and mpu401_uart) on the cvs so that the
> > > sequencer retrieves the rawmidi name string if the substream name is
> > > not defined. 
> > 
> > But Clemens' patch (attached is a slightly modified version) was not for port 
> > names but for client names, from "External MIDI x" to the more meaningful 
> > rawmidi name. I think that this is what some people is requesting, and makes 
> > things easier for large studio setups when some applications, like kaconnect, 
> > show client names but not port names. Please, apply.
> 
> I don't agree with this patch. kaconnect or other applications might 
> simply parse the string and if matches - get the real name over the 
> control interface. Otherwise, it is not clear, that the port is equal to
> a rawmidi device.

it's of course a bit dangerous to change such behavior.

but basically, the application shouldn't rely on the client name
string to get its information.  and, AFAIK, there are no applications
to do that, so far.  hence, i don't think it would cause much
problems.

if it looks ok for you, i'll commit more changes in this regard,
including:

- set the sequencer client name from rawmidi name (like above)
- reset the sequencer client name for the rawmidi device 0
  in the case that other device was registered formerly.
- set the name of mpu401_uart from card's shortname if already
  defined.

the last one requires the definition of the shortname field before
calling snd_mpu401_uart_new().  if not defined, "MPU401 (UART)" is
used like the older version.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SlickEdit Inc. Develop an edge.
The most comprehensive and flexible code editor you can use.
Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial.
www.slickedit.com/sourceforge