From: Dave Jones <davej@codemonkey.org.uk>
To: Thomas Schlichter <schlicht@uni-mannheim.de>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@digeo.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][2.5] fix preempt-issues with smp_call_function()
Date: Wed, 26 Feb 2003 09:37:42 -0100 [thread overview]
Message-ID: <20030226103742.GA29250@suse.de> (raw)
In-Reply-To: <200302251908.55097.schlicht@uni-mannheim.de>
On Tue, Feb 25, 2003 at 07:08:48PM +0100, Thomas Schlichter wrote:
> here is a patch to solve all (I hope I missed none) possible problems that
> could occur on SMP machines running a preemptible kernel when
> smp_call_function() calls a function which should be also executed on the
> current processor.
>
> This patch is based on the one Dave Jones sent to the LKML last friday and
> applies to the linux kernel version 2.5.63.
Just one comment. You moved quite a few of the preempt_disable/enable
pairs outside of the CONFIG_SMP checks. The issue we're working against
here is to try and prevent preemption and ending up on a different CPU.
As this cannot happen if CONFIG_SMP=n, I don't see why you've done this.
Dave
next prev parent reply other threads:[~2003-02-26 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-25 18:08 [PATCH][2.5] fix preempt-issues with smp_call_function() Thomas Schlichter
2003-02-26 9:27 ` Andrew Morton
2003-02-26 10:37 ` Dave Jones [this message]
2003-02-26 9:54 ` Andrew Morton
2003-02-26 10:14 ` Thomas Schlichter
2003-02-26 11:19 ` Dave Jones
2003-02-26 10:28 ` Andrew Morton
2003-02-26 10:52 ` Thomas Schlichter
2003-02-26 11:28 ` Dave Jones
2003-02-26 13:39 ` Alan Cox
2003-02-26 18:47 ` Andrew Morton
2003-02-26 20:11 ` Alan Cox
2003-02-26 16:00 ` Martin J. Bligh
-- strict thread matches above, loose matches on Subject: below --
2003-02-21 14:20 [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c w ith flush_tlb_all() Dave Jones
2003-02-21 17:36 ` Dave Jones
2003-02-22 3:23 ` [PATCH][2.5] fix preempt-issues with smp_call_function() Thomas Schlichter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030226103742.GA29250@suse.de \
--to=davej@codemonkey.org.uk \
--cc=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schlicht@uni-mannheim.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.