From: Thomas Schlichter <schlicht@uni-mannheim.de>
To: Andrew Morton <akpm@digeo.com>, Dave Jones <davej@codemonkey.org.uk>
Cc: torvalds@transmeta.com, hugh@veritas.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.5] fix preempt-issues with smp_call_function()
Date: Wed, 26 Feb 2003 11:14:30 +0100 [thread overview]
Message-ID: <200302261114.36387.schlicht@uni-mannheim.de> (raw)
In-Reply-To: <20030226015409.78e8e1fb.akpm@digeo.com>
[-- Attachment #1: signed data --]
[-- Type: text/plain, Size: 513 bytes --]
Dave Jones <davej@codemonkey.org.uk> wrote:
> Just one comment. You moved quite a few of the preempt_disable/enable
> pairs outside of the CONFIG_SMP checks. The issue we're working against
> here is to try and prevent preemption and ending up on a different CPU.
> As this cannot happen if CONFIG_SMP=n, I don't see why you've done this.
Andrew Morton wrote:
> Just in two places.
[snip]
Yes, thanks for delivering this better patch!
My approach wanted just to be the most simple possibility... ;-)
Thomas
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-02-26 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-25 18:08 [PATCH][2.5] fix preempt-issues with smp_call_function() Thomas Schlichter
2003-02-26 9:27 ` Andrew Morton
2003-02-26 10:37 ` Dave Jones
2003-02-26 9:54 ` Andrew Morton
2003-02-26 10:14 ` Thomas Schlichter [this message]
2003-02-26 11:19 ` Dave Jones
2003-02-26 10:28 ` Andrew Morton
2003-02-26 10:52 ` Thomas Schlichter
2003-02-26 11:28 ` Dave Jones
2003-02-26 13:39 ` Alan Cox
2003-02-26 18:47 ` Andrew Morton
2003-02-26 20:11 ` Alan Cox
2003-02-26 16:00 ` Martin J. Bligh
-- strict thread matches above, loose matches on Subject: below --
2003-02-21 14:20 [PATCH][2.5] replace flush_map() in arch/i386/mm/pageattr.c w ith flush_tlb_all() Dave Jones
2003-02-21 17:36 ` Dave Jones
2003-02-22 3:23 ` [PATCH][2.5] fix preempt-issues with smp_call_function() Thomas Schlichter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302261114.36387.schlicht@uni-mannheim.de \
--to=schlicht@uni-mannheim.de \
--cc=akpm@digeo.com \
--cc=davej@codemonkey.org.uk \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.